txpkgme

Merge lp://qastaging/~jml/txpkgme/fix-refactoring into lp://qastaging/txpkgme

  1. fix-refactoring
  2. Merge into trunk
Proposed by Jonathan Lange
Status: Merged
Approved by: James Westby
Approved revision: 24
Merged at revision: 24
Proposed branch: lp://qastaging/~jml/txpkgme/fix-refactoring
Merge into: lp://qastaging/txpkgme
Diff against target: 59 lines (+22/-1)
2 files modified
txpkgme/harness.py (+2/-1)
txpkgme/tests/test_harness.py (+20/-0)
To merge this branch: bzr merge lp://qastaging/~jml/txpkgme/fix-refactoring
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+117454@code.qastaging.launchpad.net

Commit message

Correctly handle failures

Description of the change

Slowly, slowly, slowly we are getting more tests for the scoreboard.

This fixes up something that I observed while running on lxc. By returning
an exception rather than a Failure, I was indicating that the errback had
handled the error successfully and that the Deferred should process from
the callback chain. That was wrong.

Really, we need a mock server to test against.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Is there a reason that "return Failure(exc)" is preferable to "raise exc"? (just for my knowledge)

Thanks,

James

review: Approve
Revision history for this message
Jonathan Lange (jml) wrote :

On 31 July 2012 16:08, James Westby <email address hidden> wrote:
> Review: Approve
>
> Is there a reason that "return Failure(exc)" is preferable to "raise exc"? (just for my knowledge)

Not really. 'raise' is a tad slower and will create a traceback. We
don't care about the traceback here.

jml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches