Merge ~jocave/checkbox/+git/checkbox-configure:wrapper-naming-nonclassic into ~checkbox-dev/checkbox/+git/checkbox-configure:master
Proposed by
Jonathan Cave
| Status: | Merged |
|---|---|
| Approved by: | Jonathan Cave |
| Approved revision: | 9c7fc12735186af01c829efe4c99dfbb926ad178 |
| Merged at revision: | 1ad4e6e656f4238a6dcc48e219ab7b1fdb6149a4 |
| Proposed branch: | ~jocave/checkbox/+git/checkbox-configure:wrapper-naming-nonclassic |
| Merge into: | ~checkbox-dev/checkbox/+git/checkbox-configure:master |
| Diff against target: |
66 lines (+6/-6) 4 files modified
launchers_v2/test-runner-automated.in (+1/-1) launchers_v2/test-runner.in (+1/-1) snap/snapcraft.yaml.in_v2 (+2/-2) snap/snapcraft_classic.yaml.in_v2 (+2/-2) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Although the use of "checkbox-cli" as the name of the wrapper script worked on classic, on non-classic it ended up stuck in an exec loop. Could possibly have been solved in other ways, but it makes more sense to me to just keep the name of the wrapper script as something different to the underlying command.
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yes please. +1