Checkbox

Merge ~jocave/checkbox/+git/checkbox-configure:no-wrapper-common-during-hook into ~checkbox-dev/checkbox/+git/checkbox-configure:master

  1. Git
  2. lp:~jocave/checkbox/+git/checkbox-configure
  3. no-wrapper-common-during-hook
  4. Merge into master
Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 12ced6b8454cc0c6c7553c9c538e0ed9ea6266f8
Merged at revision: 88136507759cce9759af1b4c13e836ac9dee0fe7
Proposed branch: ~jocave/checkbox/+git/checkbox-configure:no-wrapper-common-during-hook
Merge into: ~checkbox-dev/checkbox/+git/checkbox-configure:master
Diff against target: 38 lines (+14/-4)
2 files modified
launchers/wrapper_local.in (+7/-2)
launchers_v2/wrapper_local.in (+7/-2)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Sylvain Pineau (community) Approve
Review via email: mp+401946@code.qastaging.launchpad.net

Description of the change

Allow devmode snaps to be installed in a sideload situation where because the snaps are not coming from the store the content interface connections would not be automatically mode and this script would exit.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

much nicer than a single exit 0, +1

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks great!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches