Merge ~jocave/checkbox/+git/support:request-exact-branch into ~checkbox-dev/checkbox/+git/support:master
Proposed by
Jonathan Cave
| Status: | Merged |
|---|---|
| Approved by: | Jonathan Cave |
| Approved revision: | 3f4a84ae154cccebe1ecc94be47f06a7e9a70c24 |
| Merged at revision: | 877dbafa5fd4b71f35719c907c96b44a51874da7 |
| Proposed branch: | ~jocave/checkbox/+git/support:request-exact-branch |
| Merge into: | ~checkbox-dev/checkbox/+git/support:master |
| Diff against target: |
28 lines (+3/-2) 1 file modified
release/git/lp-propose-merge (+3/-2) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sylvain Pineau (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I found that jenkins jobs could trigger merge requests for the wrong branches because this script searches the repository for the branches to merge using an 'in' comparison rather than matching the name exactly.
I'm probably not aware of all situations where this script is used, but think this seems a bit dangerous.
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 of course (tested from an old checkbox deb release repo)