Trac-Bzr

Merge lp://qastaging/~joe.julian/trac-bzr/head-typo into lp://qastaging/trac-bzr

head-typo
Merge into trunk

Proposed by Joe Julian on 2012-01-07

Status:	Merged
Merged at revision:	123
Proposed branch:	lp://qastaging/~joe.julian/trac-bzr/head-typo
Merge into:	lp://qastaging/trac-bzr
Diff against target:	12 lines (+1/-1) 1 file modified tracbzr/backend.py (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~joe.julian/trac-bzr/head-typo
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Martin von Gagern		2012-01-07	Approve on 2012-01-07
Review via email: mp+87846@code.qastaging.launchpad.net

Description of the change

Fixes a typo in rev_older_than where 'len(heads)' is meant to be tested, but instead it tested 'len(s)' which raised an exception.

Revision history for this message

Martin von Gagern (gagern) wrote on 2012-01-07:

The fix looks good to me, will merge it shortly.

I'm somewhat surprised that I didn't encounter any problems of this kind myself yet.
What user interface operation did trigger that backtrace for you? What version of trac?

review: Approve

Revision history for this message

Joe Julian (joe.julian) wrote on 2012-01-07:

Revision Log. I noticed it with just setting "back to" to 1 and hitting
"Update".

Trac 0.12

On 01/07/2012 11:49 AM, Martin von Gagern wrote:
> Review: Approve
>
> The fix looks good to me, will merge it shortly.
>
> I'm somewhat surprised that I didn't encounter any problems of this kind myself yet.
> What user interface operation did trigger that backtrace for you? What version of trac?