Ubuntu CI Services

Merge lp://qastaging/~joetalbott/ubuntu-ci-services-itself/ds_custom_filename into lp://qastaging/ubuntu-ci-services-itself

  1. ds_custom_filename
  2. Merge into trunk
Proposed by Joe Talbott
Status: Rejected
Rejected by: Joe Talbott
Proposed branch: lp://qastaging/~joetalbott/ubuntu-ci-services-itself/ds_custom_filename
Merge into: lp://qastaging/ubuntu-ci-services-itself
Diff against target: 36 lines (+14/-1)
2 files modified
ci-utils/ci_utils/data_store/__init__.py (+5/-1)
tests/data_store/test.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~joetalbott/ubuntu-ci-services-itself/ds_custom_filename
Reviewer Review Type Date Requested Status
Andy Doan (community) Disapprove
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211050@code.qastaging.launchpad.net

Commit message

data-store - Add optional name override to put_file().

Description of the change

data-store - Add optional name override to put_file().

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:389
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/426/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/426/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

as discussed on IRC. this change doesn't really make sense.

review: Disapprove

Unmerged revisions

389. By Joe Talbott

data-store - Add optional name override to put_file().

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches