Merge lp://qastaging/~joetalbott/ubuntu-ci-services-itself/workflow_logs into lp://qastaging/ubuntu-ci-services-itself

Proposed by Joe Talbott
Status: Merged
Approved by: Chris Johnston
Approved revision: 346
Merged at revision: 392
Proposed branch: lp://qastaging/~joetalbott/ubuntu-ci-services-itself/workflow_logs
Merge into: lp://qastaging/ubuntu-ci-services-itself
Diff against target: 894 lines (+447/-100)
6 files modified
webui/cdrom.svg (+76/-0)
webui/test_webui.html (+50/-1)
webui/ticket.html (+1/-0)
webui/webui.css (+85/-20)
webui/webui.js (+234/-67)
webui/webui_ticket_list.js (+1/-12)
To merge this branch: bzr merge lp://qastaging/~joetalbott/ubuntu-ci-services-itself/workflow_logs
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Chris Johnston (community) Approve
Vincent Ladeuil (community) look and feel ;) Approve
Joe Talbott (community) Needs Resubmitting
Review via email: mp+210918@code.qastaging.launchpad.net

Commit message

webui - Add logs to the Landing Progress table.

Description of the change

webui - Add logs to the Landing Progress table.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:343
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/413/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/413/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) wrote :

Text conflict in webui/webui.css

review: Needs Fixing
Revision history for this message
Andy Doan (doanac) wrote :

joe - you have a URL up we can poke around on?

344. By Joe Talbott

Merge with trunk and cleanup webui/webui.css conflicts.

Revision history for this message
Joe Talbott (joetalbott) wrote :

@Chris - Conflicts resolved.

@Andy - Since the URL would be ephemeral I'll send it to you privately.

review: Needs Resubmitting
345. By Joe Talbott

webui - Remove Logs column from status table.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:344
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/424/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/424/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:345
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/425/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/425/rebuild

review: Approve (continuous-integration)
346. By Joe Talbott

webui - Fix row linking to support middle-click in FF.

Fixes: LP:1292559

Revision history for this message
Vincent Ladeuil (vila) wrote :

Based on what I've seen in the examples provided, I like it a lot.

review: Approve (look and feel ;))
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:346
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/428/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/428/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches