Merge lp://qastaging/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview into lp://qastaging/openlp
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 2882 | ||||||||
| Proposed branch: | lp://qastaging/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview | ||||||||
| Merge into: | lp://qastaging/openlp | ||||||||
| Diff against target: |
98 lines (+31/-11) 2 files modified
openlp/plugins/songs/forms/songreviewwidget.py (+30/-10) openlp/plugins/songs/songsplugin.py (+1/-1) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~johnmfl/openlp/delete_temp_songs_add_fields_dupsongreview | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Bentley | Approve | ||
| Tomas Groth | Approve | ||
| Raoul Snyman | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2019-06-19.
Commit message
#1832874
changed songsplugin.py from `is true` to `== True` to force the deletion of
temporary song records in the database on closing OpenLP. This may not be
proper python, but the database appears to need the `== True` to function
correctly.
#1832876
Change songreviewwidget.py to add the `last modified` date and the
`theme` used by the song. The bug lists 3 fields that would help
determine what song to delete...the user only wanted the last modified
date. I added the theme and songbook name, but the songbook name
was not added in this update...If I am the only person that wants the
songbook name it isn't worth the time to add.
Description of the change
#1832874
changed songsplugin.py from `is true` to `== True` to force the deletion of
temporary song records in the database on closing OpenLP. This may not be
proper python, but the database appears to need the `== True` to function
correctly.
#1832876
Change songreviewwidget.py to add the `last modified` date and the
`theme` used by the song. The bug lists 3 fields that would help
determine what song to delete...the user only wanted the last modified
date. I added the theme and songbook name, but the songbook name
was not added in this update...If I am the only person that wants the
songbook name it isn't worth the time to add.
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Raoul Snyman (raoul-snyman) wrote | # |
| Tomas Groth (tomasgroth) | # |
| Tim Bentley (trb143) | # |
Linux tests passed!