Ubuntu
libappindicator package

Merge lp://qastaging/~johnv/ubuntu/precise/libappindicator/bug-1122596 into lp://qastaging/ubuntu/precise/libappindicator

  1. Precise (12.04)
  2. bug-1122596
  3. Merge into precise
Proposed by John Vert
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp://qastaging/~johnv/ubuntu/precise/libappindicator/bug-1122596
Merge into: lp://qastaging/ubuntu/precise/libappindicator
Diff against target: 34 lines (+8/-2)
2 files modified
debian/changelog (+6/-0)
src/app-indicator.c (+2/-2)
To merge this branch: bzr merge lp://qastaging/~johnv/ubuntu/precise/libappindicator/bug-1122596
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
Ubuntu branches Pending
Review via email: mp+148027@code.qastaging.launchpad.net

Description of the change

app_indicator_init() in app-indicator.c calls g_bus_get() before setting self->priv. This creates a race condition where the bus_creation() callback can execute while self->priv still contains garbage. Suggested fix is to set self->priv before calling g_bus_get().

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, the fix should land in lp:libappindicator and raring before being SRUed. If you think it's worth SRUing you should also provide the informations required for that, see https://wiki.ubuntu.com/StableReleaseUpdates (needs description of the impact, a test case and a regression potential section)

review: Needs Fixing
Revision history for this message
John Vert (johnv) wrote :

> Thank you for your work, the fix should land in lp:libappindicator and raring
> before being SRUed. If you think it's worth SRUing you should also provide the
> informations required for that, see
> https://wiki.ubuntu.com/StableReleaseUpdates (needs description of the impact,
> a test case and a regression potential section)

updated bug description with the requested information

Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded this to the precise-proposed queue for review by the SRU team.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: