Bazaar

Merge lp://qastaging/~joke/bzr/file_permissions_authentication.conf into lp://qastaging/bzr

file_permissions_authentication.conf
Merge into bzr.dev

Proposed by John A Meinel on 2011-04-21

Status:

Work in progress

Proposed branch:

lp://qastaging/~joke/bzr/file_permissions_authentication.conf

Merge into:

lp://qastaging/bzr

Diff against target:

52 lines (+19/-0) (has conflicts)

1 file modified

bzrlib/config.py (+19/-0)

Text conflict in bzrlib/config.py

To merge this branch:

bzr merge lp://qastaging/~joke/bzr/file_permissions_authentication.conf

Medium

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Vincent Ladeuil		2011-04-21	Needs Information on 2011-05-06
Review via email: mp+58666@code.qastaging.launchpad.net

Commit message

Bug #475501, create authentication.conf with mode 0600

Description of the change

We currently don't do much fancy with authentication.conf permissions. Joke de Buhr reasonably pointed out that we could create the file as 600 and avoid defaulting to having your passwords accessible by other users on the system.

I haven't looked over the patch at all, just trying to get it out of the In Progress queue and get a decision on it.

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2011-05-02:

I wonder how this will do on Windows? It seems to rely on Unix modes, and it would be nice to add some tests.

Revision history for this message

John A Meinel (jameinel) wrote on 2011-05-03:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 5/3/2011 1:45 AM, Jelmer Vernooij wrote:
> I wonder how this will do on Windows? It seems to rely on Unix modes, and it would be nice to add some tests.

The attributes are all available on Windows. Probably the big concern is
that it is a bit hard to set the modes reliably, and then the warning
will occur repeatedly.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2/8IgACgkQJdeBCYSNAAONQwCfYs+M6SRAQ23cjkMe51+7EMTD
wRsAn0rJ1SE+hDQMK7XlKWmGkfc6MhSk
=vrH1
-----END PGP SIGNATURE-----

Revision history for this message

Vincent Ladeuil (vila) wrote on 2011-05-06:

The approach I've seen used in other contexts for such sensible informations seems to be:
- create the file with user-only persmissions,
- refuse to use it if others (even group) can read it

That's not exactly the approach taken here.

Now, I think windows doesn't provide this (user-only access) easily so we may just don't check there.

So what do others think ? Should we:

- create with 0600,
- warn if group or other have read access (not on windows)

- create with 0600
- refuse to use the file if group or other have read access (not on windows)

Something else ?

I'm fine with finishing this proposal if we reach a consensus, in the mean time, I'll mark this as wip.

review: Needs Information

Revision history for this message

Vincent Ladeuil (vila) wrote on 2011-05-06:

I forgot:

27 + if not GlobalConfig().get_user_option_as_bool(
28 + 'no_insecure_permissions_warning') :

We have a suppress_warnings config option that should be used here instead of introducing a new one (it's a list of warning names that should not be displayed, see bzrlib.config.Config.suppress_warning.

Unmerged revisions

4791. By Joke de Buhr on 2009-11-06: Don't emit warning message if the option 'no_insecure_permissions_warning'
is set to 'True' in bazaar.conf [DEFAULT]
4790. By Joke de Buhr on 2009-11-05: Emit warning message if an authentication.conf file hase insecure file permissions.
4789. By Joke de Buhr on 2009-11-05: create authentication.conf with umask 166 (permissions: u=rw,go=)