poll-daemon

Merge lp://qastaging/~jonas-drange/account-polld/gmail-missing-notifications into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

  1. gmail-missing-notifications
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 159
Merged at revision: 149
Proposed branch: lp://qastaging/~jonas-drange/account-polld/gmail-missing-notifications
Merge into: lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Diff against target: 175 lines (+58/-54)
2 files modified
cmd/account-polld/main.go (+15/-42)
plugins/gmail/gmail.go (+43/-12)
To merge this branch: bzr merge lp://qastaging/~jonas-drange/account-polld/gmail-missing-notifications
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+280711@code.qastaging.launchpad.net

Commit message

- Force parsing of email address even if it violates RFC 5322.
- Encode icon file paths since unity-notifications require it.
- Summarize notification bubbles when > 10 in a batch, but never summarize in the indicator.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

Given the level of insanity of this codepath, this does not seem worse than what we have :-)

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:150
http://jenkins.qa.ubuntu.com/job/account-polld-ci/94/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/94/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:159
http://jenkins.qa.ubuntu.com/job/account-polld-ci/95/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-vivid-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/95/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works well!

review: Approve
Revision history for this message
John Lenton (chipaca) wrote :

My 'approve' stands.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches