Merge lp://qastaging/~jonas-drange/ubuntu-settings-components/printer-remove into lp://qastaging/~phablet-team/ubuntu-settings-components/printer-components
Proposed by
Jonas G. Drange
| Status: | Rejected |
|---|---|
| Rejected by: | Jonas G. Drange |
| Proposed branch: | lp://qastaging/~jonas-drange/ubuntu-settings-components/printer-remove |
| Merge into: | lp://qastaging/~phablet-team/ubuntu-settings-components/printer-components |
| Prerequisite: | lp://qastaging/~jonas-drange/ubuntu-settings-components/cups-notifications |
| Diff against target: |
168 lines (+68/-3) 8 files modified
examples/Printers.qml (+12/-0) plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp (+1/-1) plugins/Ubuntu/Settings/Printers/cups/cupsfacade.cpp (+3/-1) plugins/Ubuntu/Settings/Printers/cups/cupspkhelper.cpp (+22/-0) plugins/Ubuntu/Settings/Printers/cups/cupspkhelper.h (+4/-0) plugins/Ubuntu/Settings/Printers/printers/printers.cpp (+6/-0) tests/unittests/Printers/mockbackend.h (+6/-1) tests/unittests/Printers/tst_printers.cpp (+14/-0) |
| To merge this branch: | bzr merge lp://qastaging/~jonas-drange/ubuntu-settings-components/printer-remove |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Hayzen (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
adds removal of printer
Description of the change
adds removal of printer
To post a comment you must log in.
Unmerged revisions
- 227. By Jonas G. Drange
-
syncs with prereq branch
- 226. By Jonas G. Drange
-
adds removal of printer
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
After deleting a printer from the QML UI, the listview of printers freezes for me. I'm able to click add new printer, but not able to click on any printer delegates or right click on them - I have to restart the app.