Merge lp://qastaging/~jonas-drange/ubuntu-system-settings/updates-rewrite into lp://qastaging/ubuntu-system-settings

Proposed by Jonas G. Drange
Status: Superseded
Proposed branch: lp://qastaging/~jonas-drange/ubuntu-system-settings/updates-rewrite
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 21093 lines (+14964/-3779)
182 files modified
cmake/QmlTest.cmake (+130/-0)
debian/control (+5/-0)
plugins/about/PageComponent.qml (+4/-5)
plugins/about/Version.qml (+6/-7)
plugins/cellular/Components/MultiSim.qml (+0/-5)
plugins/system-update/CMakeLists.txt (+65/-21)
plugins/system-update/ChangelogExpander.qml (+77/-0)
plugins/system-update/ClickUpdateDelegate.qml (+38/-0)
plugins/system-update/Configuration.qml (+3/-3)
plugins/system-update/DownloadHandler.qml (+184/-0)
plugins/system-update/EntryComponent.qml (+26/-20)
plugins/system-update/Global.qml (+143/-0)
plugins/system-update/ImageUpdatePrompt.qml (+52/-0)
plugins/system-update/NotAuthenticatedNotification.qml (+55/-0)
plugins/system-update/PageComponent.qml (+353/-679)
plugins/system-update/UpdateDelegate.qml (+480/-0)
plugins/system-update/Updates.qml (+376/-0)
plugins/system-update/click/client.h (+82/-0)
plugins/system-update/click/client_impl.cpp (+216/-0)
plugins/system-update/click/client_impl.h (+56/-0)
plugins/system-update/click/manager.h (+84/-0)
plugins/system-update/click/manager_impl.cpp (+521/-0)
plugins/system-update/click/manager_impl.h (+118/-0)
plugins/system-update/click/manifest.h (+46/-0)
plugins/system-update/click/manifest_impl.cpp (+97/-0)
plugins/system-update/click/manifest_impl.h (+47/-0)
plugins/system-update/click/sso.h (+56/-0)
plugins/system-update/click/sso_impl.cpp (+63/-0)
plugins/system-update/click/sso_impl.h (+54/-0)
plugins/system-update/click/tokendownloader.h (+70/-0)
plugins/system-update/click/tokendownloader_factory.h (+44/-0)
plugins/system-update/click/tokendownloader_factory_impl.cpp (+36/-0)
plugins/system-update/click/tokendownloader_factory_impl.h (+38/-0)
plugins/system-update/click/tokendownloader_impl.cpp (+103/-0)
plugins/system-update/click/tokendownloader_impl.h (+49/-0)
plugins/system-update/download_tracker.cpp (+0/-204)
plugins/system-update/download_tracker.h (+0/-106)
plugins/system-update/helpers.cpp (+114/-0)
plugins/system-update/helpers.h (+48/-0)
plugins/system-update/image/imagemanager.h (+59/-0)
plugins/system-update/image/imagemanager_impl.cpp (+178/-0)
plugins/system-update/image/imagemanager_impl.h (+71/-0)
plugins/system-update/network.cpp (+0/-314)
plugins/system-update/network.h (+0/-85)
plugins/system-update/network/accessmanager.h (+50/-0)
plugins/system-update/network/accessmanager_impl.cpp (+48/-0)
plugins/system-update/network/accessmanager_impl.h (+41/-0)
plugins/system-update/plugin.cpp (+24/-17)
plugins/system-update/plugin.h (+0/-1)
plugins/system-update/plugin/CMakeLists.txt (+0/-14)
plugins/system-update/plugin/update-plugin.cpp (+0/-98)
plugins/system-update/plugin/update-plugin.h (+0/-39)
plugins/system-update/qmldir (+0/-2)
plugins/system-update/qmldir.in (+2/-0)
plugins/system-update/system_update.cpp (+0/-281)
plugins/system-update/system_update.h (+0/-106)
plugins/system-update/systemupdate.cpp (+216/-0)
plugins/system-update/systemupdate.h (+126/-0)
plugins/system-update/update-notification.settings (+1/-2)
plugins/system-update/update.cpp (+0/-179)
plugins/system-update/update.h (+0/-161)
plugins/system-update/update_manager.cpp (+0/-398)
plugins/system-update/update_manager.h (+0/-181)
plugins/system-update/updatedb.cpp (+380/-0)
plugins/system-update/updatedb.h (+102/-0)
plugins/system-update/updatemodel.cpp (+601/-0)
plugins/system-update/updatemodel.h (+183/-0)
src/CMakeLists.txt (+12/-4)
src/main.cpp (+3/-0)
src/systemimage.cpp (+472/-0)
src/systemimage.h (+189/-0)
tests/CMakeLists.txt (+28/-2)
tests/autopilot/ubuntu_system_settings/tests/downloadmanager.py (+173/-0)
tests/autopilot/ubuntu_system_settings/tests/systemimage.py (+149/-37)
tests/autopilot/ubuntu_system_settings/utils/mock_update_click_server.py (+74/-28)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+25/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+52/-0)
tests/mocks/QMenuModel/actiondata.h (+54/-0)
tests/mocks/QMenuModel/actionstateparser.cpp (+19/-0)
tests/mocks/QMenuModel/actionstateparser.h (+35/-0)
tests/mocks/QMenuModel/dbus-enums.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+40/-0)
tests/mocks/QMenuModel/plugin.h (+34/-0)
tests/mocks/QMenuModel/qmldir (+4/-0)
tests/mocks/Ubuntu/CMakeLists.txt (+3/-0)
tests/mocks/Ubuntu/Connectivity/CMakeLists.txt (+15/-0)
tests/mocks/Ubuntu/Connectivity/MockNetworkingStatus.cpp (+83/-0)
tests/mocks/Ubuntu/Connectivity/MockNetworkingStatus.h (+78/-0)
tests/mocks/Ubuntu/Connectivity/plugin.cpp (+40/-0)
tests/mocks/Ubuntu/Connectivity/plugin.h (+36/-0)
tests/mocks/Ubuntu/Connectivity/qmldir (+2/-0)
tests/mocks/Ubuntu/DownloadManager/CMakeLists.txt (+17/-0)
tests/mocks/Ubuntu/DownloadManager/MockDownloadManager.cpp (+90/-0)
tests/mocks/Ubuntu/DownloadManager/MockDownloadManager.h (+68/-0)
tests/mocks/Ubuntu/DownloadManager/MockMetadata.cpp (+73/-0)
tests/mocks/Ubuntu/DownloadManager/MockMetadata.h (+64/-0)
tests/mocks/Ubuntu/DownloadManager/MockSingleDownload.cpp (+206/-0)
tests/mocks/Ubuntu/DownloadManager/MockSingleDownload.h (+113/-0)
tests/mocks/Ubuntu/DownloadManager/plugin.cpp (+31/-0)
tests/mocks/Ubuntu/DownloadManager/plugin.h (+31/-0)
tests/mocks/Ubuntu/DownloadManager/qmldir (+2/-0)
tests/mocks/Ubuntu/OnlineAccounts/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/CMakeLists.txt (+19/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/MockSetup.cpp (+59/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/MockSetup.h (+59/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/plugin.cpp (+29/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/plugin.h (+33/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/qmldir (+2/-0)
tests/mocks/Ubuntu/SystemSettings/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/SystemSettings/Update/CMakeLists.txt (+29/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemImage.cpp (+89/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemImage.h (+73/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemUpdate.cpp (+48/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemUpdate.h (+39/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateModel.cpp (+45/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateModel.h (+50/-0)
tests/mocks/Ubuntu/SystemSettings/Update/plugin.cpp (+51/-0)
tests/mocks/Ubuntu/SystemSettings/Update/plugin.h (+33/-0)
tests/mocks/Ubuntu/SystemSettings/Update/qmldir (+2/-0)
tests/mocks/plugins/system-update/fakeclickmanager.h (+90/-0)
tests/mocks/plugins/system-update/fakeclient.h (+75/-0)
tests/mocks/plugins/system-update/fakeimagemanager.h (+57/-0)
tests/mocks/plugins/system-update/fakemanifest.h (+50/-0)
tests/mocks/plugins/system-update/fakesso.h (+55/-0)
tests/mocks/plugins/system-update/faketokendownloader.h (+67/-0)
tests/mocks/plugins/system-update/faketokendownloader_factory.h (+53/-0)
tests/mocks/system-image-dbus/fakesystemimagedbus.cpp (+45/-0)
tests/mocks/system-image-dbus/fakesystemimagedbus.h (+64/-0)
tests/plugins/CMakeLists.txt (+49/-1)
tests/plugins/mouse/CMakeLists.txt (+0/-37)
tests/plugins/mouse/tst_mouse.cpp (+0/-22)
tests/plugins/mouse/tst_mouse.qml (+17/-10)
tests/plugins/security-privacy/CMakeLists.txt (+1/-1)
tests/plugins/system-update/CMakeLists.txt (+121/-52)
tests/plugins/system-update/Source/qmldir (+9/-0)
tests/plugins/system-update/click.result (+12/-3)
tests/plugins/system-update/fakenetwork.cpp (+0/-50)
tests/plugins/system-update/fakenetwork.h (+0/-60)
tests/plugins/system-update/fakeprocess.cpp (+0/-63)
tests/plugins/system-update/fakeprocess.h (+0/-48)
tests/plugins/system-update/fakessoservice.cpp (+0/-27)
tests/plugins/system-update/fakessoservice.h (+0/-35)
tests/plugins/system-update/fakesystemupdate.cpp (+0/-28)
tests/plugins/system-update/fakesystemupdate.h (+0/-68)
tests/plugins/system-update/mockclickcommand (+15/-0)
tests/plugins/system-update/mockclickserver.h (+43/-0)
tests/plugins/system-update/mockclickserver.py (+220/-0)
tests/plugins/system-update/tst_clickclient.cpp (+164/-0)
tests/plugins/system-update/tst_clickmanager.cpp (+491/-0)
tests/plugins/system-update/tst_clickmanifest.cpp (+100/-0)
tests/plugins/system-update/tst_helpers.cpp (+77/-0)
tests/plugins/system-update/tst_imagemanager.cpp (+269/-0)
tests/plugins/system-update/tst_network.cpp (+0/-58)
tests/plugins/system-update/tst_systemupdate.cpp (+191/-0)
tests/plugins/system-update/tst_systemupdate_click_update.qml (+59/-0)
tests/plugins/system-update/tst_systemupdate_download_handler.qml (+214/-0)
tests/plugins/system-update/tst_systemupdate_entrycomponent.qml (+108/-0)
tests/plugins/system-update/tst_systemupdate_global.qml (+299/-0)
tests/plugins/system-update/tst_systemupdate_noauthentication.qml (+71/-0)
tests/plugins/system-update/tst_systemupdate_pagecomponent.qml (+336/-0)
tests/plugins/system-update/tst_systemupdate_update.qml (+397/-0)
tests/plugins/system-update/tst_systemupdate_update_visuals.qml (+226/-0)
tests/plugins/system-update/tst_tokendownloader.cpp (+109/-0)
tests/plugins/system-update/tst_update.cpp (+0/-55)
tests/plugins/system-update/tst_updatedb.cpp (+214/-0)
tests/plugins/system-update/tst_updatemanager.cpp (+0/-162)
tests/plugins/system-update/tst_updatemodel.cpp (+616/-0)
tests/tst_systemimage.cpp (+279/-0)
tests/utils/CMakeLists.txt (+1/-0)
tests/utils/modules/CMakeLists.txt (+1/-0)
tests/utils/modules/Ubuntu/CMakeLists.txt (+1/-0)
tests/utils/modules/Ubuntu/Test/CMakeLists.txt (+27/-0)
tests/utils/modules/Ubuntu/Test/TouchEventSequenceWrapper.cpp (+47/-0)
tests/utils/modules/Ubuntu/Test/TouchEventSequenceWrapper.h (+42/-0)
tests/utils/modules/Ubuntu/Test/UbuntuTestCase.qml (+319/-0)
tests/utils/modules/Ubuntu/Test/plugin.cpp (+54/-0)
tests/utils/modules/Ubuntu/Test/plugin.h (+33/-0)
tests/utils/modules/Ubuntu/Test/qmldir (+3/-0)
tests/utils/modules/Ubuntu/Test/testutil.cpp (+73/-0)
tests/utils/modules/Ubuntu/Test/testutil.h (+48/-0)
ubuntu-system-settings.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~jonas-drange/ubuntu-system-settings/updates-rewrite
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Touch System Settings Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+301564@code.qastaging.launchpad.net

Commit message

rewrite the system update panel

To post a comment you must log in.
1796. By Jonas G. Drange

merge prereq

1797. By Jonas G. Drange

address own comments

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1795
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/60/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1077/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1077
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/974
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/974
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/974
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/963/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/963/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/60/rebuild

review: Needs Fixing (continuous-integration)
1798. By Jonas G. Drange

attempt to clean up xvfb mess

1799. By Jonas G. Drange

show installation failure

1800. By Jonas G. Drange

allow checks to resume after network failure

1801. By Jonas G. Drange

log a bit more sanely

1802. By Jonas G. Drange

figure out sso failure

1803. By Jonas G. Drange

stop recursiveness in sso interaction

1804. By Jonas G. Drange

fix namespacing issues, show auth only when idle

1805. By Jonas G. Drange

only hide auth box if we're done with click checking

1806. By Jonas G. Drange

do check anyway

1807. By Jonas G. Drange

sync in click manager on click apps only

1808. By Jonas G. Drange

better ui for login box

1809. By Jonas G. Drange

properly hide things when not online

1810. By Jonas G. Drange

reset an error if there's progress/isntallation or processing

1811. By Jonas G. Drange

don't ask for new tokens all the time

1812. By Jonas G. Drange

don't swallow credentialError from token downloader

1813. By Jonas G. Drange

fix broken credentials story

1814. By Jonas G. Drange

fix annoying namespace issue

1815. By Jonas G. Drange

make session tokens testable

1816. By Jonas G. Drange

don't unconditionally unset token

1817. By Jonas G. Drange

fix typo

1818. By Jonas G. Drange

do check on existing updates when parsing metadata

1819. By Jonas G. Drange

lte, not gte in check on update age

1820. By Jonas G. Drange

log a bit, and set a proper url

1821. By Jonas G. Drange

log a bit in SI

1822. By Jonas G. Drange

is it called at all?

1823. By Jonas G. Drange

move SI out of the maincpp context, into each plugin as it should

1824. By Jonas G. Drange

refactor some testing, and test using session token

1825. By Jonas G. Drange

unused args in fake session token

1826. By Jonas G. Drange

rename the client to ApiClient

1827. By Jonas G. Drange

implement launching using triplet with wildcard

1828. By Jonas G. Drange

log packageName

1829. By Jonas G. Drange

use identifier as documentation calls for for app launch

1830. By Jonas G. Drange

just pass the launch success or failure onto the caller

1831. By Jonas G. Drange

disable indeterminate progress bar as it is broken (see lp:1587176)

1832. By Jonas G. Drange

disable tests that somehow cause segfaults on armhf

1833. By Jonas G. Drange

remove unnecessary click update delegate test, and disable the pagecomponent test temporarily

1834. By Jonas G. Drange

make date test saner by only instantiating one datetime

1835. By Jonas G. Drange

attempt to re-introduce xvfb command that ken made

1836. By Jonas G. Drange

remove cruft in systemimage mock

1837. By Jonas G. Drange

undo id override

1838. By Jonas G. Drange

use minimal platform

1839. By Jonas G. Drange

explicitly unset xcb as qt_qpa_platform for non-graphical tests

1840. By Jonas G. Drange

use two xvfb commands

1841. By Jonas G. Drange

resume should work for image update

1842. By Jonas G. Drange

re-add xvfb set for bluetooth

1843. By Jonas G. Drange

re-add xvfb command for notifications panel

1844. By Jonas G. Drange

add call to download at image manger startup

1845. By Jonas G. Drange

only download at creation if a download was in progress

1846. By Jonas G. Drange

avoid breaking string freeze (too heavily)

1847. By Jonas G. Drange

do not wait for build number to mark it as installed, do it at startup

1848. By Jonas G. Drange

fix test I broke by reverting some string changes

1849. By Jonas G. Drange

make test failures more meaningful

1850. By Jonas G. Drange

transition on remove

1851. By Jonas G. Drange

listeview and re-add label for global

1852. By Jonas G. Drange

revert listview changes, need to use repeater since there's already a flickable

1853. By Jonas G. Drange

revert command comment

1854. By Jonas G. Drange

deal with transitions later

1855. By Jonas G. Drange

timeout if downloading or queued too

1856. By Jonas G. Drange

remove unnecessary assertion

1857. By Jonas G. Drange

address comments

1858. By Jonas G. Drange

be specific about width

1859. By Jonas G. Drange

include new strings, remove logging and other things unused

1860. By Jonas G. Drange

fix typo, change visuals test a bit

1861. By Jonas G. Drange

fix typo

1862. By Jonas G. Drange

use explicitly set width on the mainSlots topmost item

1863. By Jonas G. Drange

we can't make any assumptions as to what state the system updates page will be in, so drop the assertion

1864. By Jonas G. Drange

stop using minimal qpa plugin, instead use guiless main

1865. By Jonas G. Drange

use guiless main for all non-graphical tests

1866. By Jonas G. Drange

guiless, not appless

1867. By Jonas G. Drange

let otas be branded as such

1868. By Jonas G. Drange

echo qprocess output

1869. By Jonas G. Drange

try starting a server using various ports.

1870. By Jonas G. Drange

rename SystemUpdate -> UpdateManager as requested by Ken, delete unused downloadmanager mock

1871. By Jonas G. Drange

add functionality for reverted updates, finish renaming, and add schema versioning

1872. By Jonas G. Drange

enable pagecomponent tests, fix broken checking logic

1873. By Jonas G. Drange

don't nuke tokens etc when marking as uninstalled

1874. By Jonas G. Drange

log a bit, and unset download id if uninstalled

1875. By Jonas G. Drange

when restoring UDM download, listen to process. Remove fixmes

1876. By Jonas G. Drange

link uss

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches