Juju Charms Collection
hbase package

Merge lp://qastaging/~jose/charms/precise/hbase/add-icon into lp://qastaging/charms/hbase

  1. Precise Pangolin (12.04)
  2. add-icon
  3. Merge into trunk
Proposed by José Antonio Rey
Status: Merged
Merged at revision: 22
Proposed branch: lp://qastaging/~jose/charms/precise/hbase/add-icon
Merge into: lp://qastaging/charms/hbase
Diff against target: 282 lines (+278/-0)
1 file modified
icon.svg (+278/-0)
To merge this branch: bzr merge lp://qastaging/~jose/charms/precise/hbase/add-icon
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+212925@code.qastaging.launchpad.net

Commit message

Added icon

Description of the change

Added icon for the charm

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

The background seems to clash a bit with this icon. Maybe a more neutral grey color would be better?

review: Needs Fixing
lp://qastaging/~jose/charms/precise/hbase/add-icon updated
23. By José Antonio Rey

Changed icon background color to a soft-ish gray

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: