Merge lp://qastaging/~jose/ubuntu-community-accomplishments/ubuntu-youth-accomplishment into lp://qastaging/ubuntu-community-accomplishments

Proposed by José Antonio Rey
Status: Merged
Merged at revision: 217
Proposed branch: lp://qastaging/~jose/ubuntu-community-accomplishments/ubuntu-youth-accomplishment
Merge into: lp://qastaging/ubuntu-community-accomplishments
Diff against target: 66 lines (+50/-0)
3 files modified
accomplishments/ubuntu-community/en/general/ubuntu-youth.accomplishment (+17/-0)
scripts/ubuntu-community/general/ubuntu-youth.py (+28/-0)
tests/ubuntu-community/general/ubuntu-youth (+5/-0)
To merge this branch: bzr merge lp://qastaging/~jose/ubuntu-community-accomplishments/ubuntu-youth-accomplishment
Reviewer Review Type Date Requested Status
Matt Fischer Needs Fixing
Rafał Cieślak Needs Fixing
Review via email: mp+118679@code.qastaging.launchpad.net

Commit message

Added Ubuntu Youth membership accomplishment.

Description of the change

Added Ubuntu Youth membership accomplishment.

To post a comment you must log in.
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Nice work. Several notes that will require to be fixed up:
 * It looks to me as if you accidentally saved a wrong file as the .png icon. This is an HTML webpage at the moment, not a trophy icon :-)
 * In .accomplishment file fields "tips" and "pitfalls" have "none" as their value, in this case they both should be removed.
 * It would be awesome if you could expand the summary and steps fields. This has be be documentation for those who have no idea what Ubuntu Youth is - at least a short outline of what kind of activities are expected from team members, and what it's all about.

review: Needs Fixing
214. By José Antonio Rey <email address hidden>

Fixed errors mentioned in comment #1 of MP #118679

Revision history for this message
Matt Fischer (mfisch) wrote :

Two small comments on grammar:

"getting youth people started" should be "getting young people started" or if you want to use the word "youth" just drop "people", as in "getting youth started"

"and asking for mentorship if it is needed in any case,", here please just drop the "in any case" as it is not needed.

review: Needs Fixing
215. By José Antonio Rey

Fixed grammar errors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: