Merge lp://qastaging/~josharenson/unity8/allow-page-header-to-set-color into lp://qastaging/unity8
Proposed by
Josh Arenson
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid |
| Approved revision: | 2314 |
| Merged at revision: | 2369 |
| Proposed branch: | lp://qastaging/~josharenson/unity8/allow-page-header-to-set-color |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
12 lines (+1/-1) 1 file modified
qml/Dash/DashPageHeader.qml (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~josharenson/unity8/allow-page-header-to-set-color |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Make scope filter settings button the same color as other foreground elements
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes, clean
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
I'm sure this is ok :-)
To post a comment you must log in.
Revision history for this message
| Josh Arenson (josharenson) wrote | # |
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
If you want to test this easily, I modified a scope so that the page header elements are supposed to be blue. Just wget and install the following click package.
https:/