Merge lp://qastaging/~josvaz/charms/trusty/bip/client_side_ssl-with_helper-lp1604894 into lp://qastaging/charms/trusty/bip
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~josvaz/charms/trusty/bip/client_side_ssl-with_helper-lp1604894 | ||||
Merge into: | lp://qastaging/charms/trusty/bip | ||||
Prerequisite: | lp://qastaging/~josvaz/charms/trusty/bip/charmhelpers-cleanup | ||||
Diff against target: |
618 lines (+496/-7) 8 files modified
charm-helpers.yaml (+1/-0) config.yaml (+4/-0) hooks/hooks.py (+30/-6) lib/charmhelpers/contrib/__init__.py (+13/-0) lib/charmhelpers/contrib/ssl/__init__.py (+92/-0) lib/charmhelpers/contrib/ssl/service.py (+277/-0) templates/bip_conf.template (+1/-1) tests/11-deploy-ssl (+78/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~josvaz/charms/trusty/bip/client_side_ssl-with_helper-lp1604894 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Review Queue (community) | automated testing | Approve | |
Brad Marshall (community) | Approve | ||
Pen Gale (community) | Approve | ||
charmers | Pending | ||
Review via email: mp+301802@code.qastaging.launchpad.net |
Description of the change
This should replace https:/
It goes after this MP:
https:/
And fixes:
https:/
X-CPC-Summary-Skip: 1
Unmerged revisions
- 32. By Jose L. VG
-
Adding a bip ssl deploy test (validates cert & handshake)
- 31. By Jose L. VG
-
Added support to client_side_ssl with charmhelper contrib.ssl
- 30. By Jose L. VG
-
Got charmhelpers for fetch as apt_install is now there
- 29. By Jose L. VG
-
Moved from charm-helpers/
charmhelpers to just charmhelpers (plus clean-up) - 28. By Jose L. VG
-
Result of removing charmhelpers and re-syncing it
- 27. By Jose L. VG
-
Added charm-helpers.yaml to manage helpers with charm_helpers_sync tool
- 26. By Jose L. VG
-
Flake8 suggested fixes, including unused imports
This has been tested on a juju setup on GCE