Unity Videos Lens

Merge lp://qastaging/~jpakkane/unity-lens-video/coverage into lp://qastaging/~stolowski/unity-lens-video/vala-rewrite

  1. coverage
  2. Merge into vala-rewrite
Proposed by Jussi Pakkanen
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 157
Merged at revision: 156
Proposed branch: lp://qastaging/~jpakkane/unity-lens-video/coverage
Merge into: lp://qastaging/~stolowski/unity-lens-video/vala-rewrite
Diff against target: 269 lines (+171/-7)
7 files modified
Makefile.am (+2/-0)
Makefile.am.coverage (+48/-0)
configure.ac (+16/-0)
m4/gcov.m4 (+86/-0)
src/Makefile.am (+3/-0)
tests/unit/Makefile.am (+15/-7)
tests/unit/config-tests.vala.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~jpakkane/unity-lens-video/coverage
Reviewer Review Type Date Requested Status
Paweł Stołowski Approve
Review via email: mp+148700@code.qastaging.launchpad.net

Commit message

Coverage support.

Description of the change

Coverage support.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Please also update sources in tests/unit/Makefile.am to include all vala files from src/ (except for config.vala, main.vala and mocked class(es)). That way coverage report will be more accurate.

Apart from that it works fine.

review: Needs Fixing
lp://qastaging/~jpakkane/unity-lens-video/coverage updated
156. By Jussi Pakkanen

Merged changes.

157. By Jussi Pakkanen

Added vala sources to list so they show up in coverage measurements.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches