Merge lp://qastaging/~jpakkane/url-dispatcher/always into lp://qastaging/url-dispatcher/15.04

Proposed by Jussi Pakkanen
Status: Merged
Approved by: Ted Gould
Approved revision: 77
Merged at revision: 78
Proposed branch: lp://qastaging/~jpakkane/url-dispatcher/always
Merge into: lp://qastaging/url-dispatcher/15.04
Diff against target: 72 lines (+23/-15)
2 files modified
service/url-db.c (+15/-14)
tests/url-db-test.cc (+8/-1)
To merge this branch: bzr merge lp://qastaging/~jpakkane/url-dispatcher/always
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+240020@code.qastaging.launchpad.net

Commit message

Ensure that tables always exist.

Description of the change

Ensure that tables always exist.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Thinking for this one we should probably have a test that runs the create sql twice, just to ensure we don't accidentally add something to that SQL which doesn't handle being run twice.

review: Needs Information
76. By Jussi Pakkanen

Created test for double creation.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
77. By Jussi Pakkanen

Dammit.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Added.

Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches