Do Plugins

Merge lp://qastaging/~jpds/do-plugins/notification-error-messages into lp://qastaging/do-plugins

Proposed by Jonathan Davies on 2009-03-13

Status:	Superseded
Proposed branch:	lp://qastaging/~jpds/do-plugins/notification-error-messages
Merge into:	lp://qastaging/do-plugins
Diff against target:	None lines
To merge this branch:	bzr merge lp://qastaging/~jpds/do-plugins/notification-error-messages
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Do Plugins Team		2009-03-13	Pending
Review via email: mp+4473@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2009-03-26.

Revision history for this message

Jonathan Davies (jpds) wrote on 2009-03-13:

Instead of returning Do saying that there was an error pasting text, throw a notification bubble if no text is provided.

572. By Jonathan Davies on 2009-03-13: Changed exception for a yield break.
573. By Jonathan Davies on 2009-03-13: Change error occured while pasting to notification bubble too.
574. By Jonathan Davies on 2009-03-14: LocateFiles: Use notification bubbles for errors and messages.
575. By Jonathan Davies on 2009-03-16: * RememberTheMilk: Added a notification bubble pop-up if no new task name is
provided.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

 === modified file 'Pastebin/src/PastebinAction.cs'
 --- Pastebin/src/PastebinAction.cs	2009-01-02 06:17:21 +0000
 +++ Pastebin/src/PastebinAction.cs	2009-03-13 22:26:52 +0000
@@ -96,6 +96,13 @@
  				text += titem.Text;
+ 			}
++			if (string.IsNullOrEmpty(text))
++			{
++				Services.Notifications.Notify("Pastebin",
++					"No text provided for pasting.");
++				throw new ArgumentNullException();
++			}
++
  			IPastebinProvider pastebinProvider = null;
  			if (modifierItems.Any ()) {