Merge lp://qastaging/~jpds/friends/linkedin-protocol into lp://qastaging/~super-friends/friends/trunk-next

Ok, looks mostly good. You're missing test coverage, however. Please see tests/test_twitter.py to see how we mock away everything and test just the methods you wrote. Also, please include a raw JSON dump from the server so that we know things are actually working ;-)

Other than that, just some small nitpicks:

* person.get('siteStandardProfileRequest').get('url')

Code like that should really be like this instead:

* person.get('siteStandardProfileRequest', {}).get('url', '')

And generally all calls to .get() should provide a default value. This allows the plugin to be robust and still publish something in the event that some of the data is missing for whatever unpredictable reason.

Also, you have this comment:

# Posts gives us a likes dict, while replies give us an int.

Although the code that follows it does not agree with what is written in the comment. Is that just a copy&paste error from the Facebook plugin? If so, can you delete that comment? ;-)

Thanks Jonathan!

Also, it looks like your contacts implementation is incomplete. It downloads the contacts (which I saw in the debugging output), but it doesn't call self._push_to_eds in order to actually save those contacts (so they're just downloaded and then discarded currently).

Any word on test coverage for this, Jon?

Superceded by https://code.launchpad.net/~robru/friends/linkedin-protocol/+merge/175416