Unity

Merge lp://qastaging/~jrrowe89/unity/Fix-for-bug-717250 into lp://qastaging/unity

Fix-for-bug-717250
Merge into trunk

Proposed by Jamie Rowe on 2011-03-08

Status:

Merged

Merged at revision:

940

Proposed branch:

lp://qastaging/~jrrowe89/unity/Fix-for-bug-717250

Merge into:

lp://qastaging/unity

Diff against target:

52 lines (+26/-6)

1 file modified

src/Launcher.cpp (+26/-6)

To merge this branch:

bzr merge lp://qastaging/~jrrowe89/unity/Fix-for-bug-717250

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Neil J. Patel (community)		Approve on 2011-03-10
Mirco Müller	2011-03-08	Pending
Review via email: mp+52545@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-03-07.

Description of the change

Dropping a .desktop file over the trash icon will now delete the file.

This fix also adds checks to ensure that the extra space for a new icon is only added when the icon being dragged is in the correct area rather than over any part of the launcher. The extra space will be removed when the icon is dragged to an area where it cannot be added from an area in which it could be.

Revision history for this message

Mirco Müller (macslow) wrote on 2011-03-07: Posted in a previous version of this proposal

Hm... I tried this and don't see a change in behaviour with your patch applied.

review: Needs Fixing

Revision history for this message

Jamie Rowe (jrrowe89) wrote on 2011-03-08: Posted in a previous version of this proposal

> Hm... I tried this and don't see a change in behaviour with your patch
> applied.

Yes, I have misunderstood the bug description.

Rather than fix the action of dnd'ing the icon to the trash I have only fixed the action of the Launcher's icons. I will make the correct changes now.

Revision history for this message

Neil J. Patel (njpatel) wrote on 2011-03-10:

Works perfectly, approved and merged, thanks!

review: Approve