SEPA Tools for OpenERP

Merge lp://qastaging/~jsancho/sepa-tools/make-payments-6.0 into lp://qastaging/sepa-tools/6.0

  1. make-payments-6.0
  2. Merge into 6.0
Proposed by Javier Sancho
Status: Needs review
Proposed branch: lp://qastaging/~jsancho/sepa-tools/make-payments-6.0
Merge into: lp://qastaging/sepa-tools/6.0
Diff against target: 55 lines (+6/-4)
2 files modified
account_payment_export/model/account_payment.py (+1/-4)
account_payment_sepa_direct_debit/sdd_mandate_view.xml (+5/-0)
To merge this branch: bzr merge lp://qastaging/~jsancho/sepa-tools/make-payments-6.0
Reviewer Review Type Date Requested Status
Omar (Pexego) test Needs Fixing
Ignacio Ibeas (www.acysos.com) Needs Fixing
Santi Argüeso(Pexego) (community) Disapprove
Review via email: mp+209408@code.qastaging.launchpad.net

Description of the change

Make payments in payment orders using other modules functionality and respecting inheritance.

To post a comment you must log in.
Revision history for this message
Ignacio Ibeas (www.acysos.com) (ignacio-acysos) :
review: Approve
Reply
Revision history for this message
Omar (Pexego) (omar7r) :
review: Approve (test)
Reply
Revision history for this message
Santi Argüeso(Pexego) (santiago-pexego) wrote :

Is not necessary to call super in super(payment_order, self).set_done(cr, uid, ids, context).
Only self).set_done(cr, uid, ids, context)

review: Disapprove
Reply
Revision history for this message
Ignacio Ibeas (www.acysos.com) (ignacio-acysos) wrote :

It's ok the Santi's Comment.

It's better call directly set_done.

Thank you

review: Needs Fixing
Reply
Revision history for this message
Omar (Pexego) (omar7r) :
review: Needs Fixing (test)
Reply
lp://qastaging/~jsancho/sepa-tools/make-payments-6.0 updated
12. By Javier Sancho <jsancho@bespin>

[FIX] account_payment_export: make payments calling parent class

Revision history for this message
Javier Sancho (jsancho) wrote :

Sorry for the delay. Fixed.

Reply

Unmerged revisions

12. By Javier Sancho <jsancho@bespin>

[FIX] account_payment_export: make payments calling parent class

11. By Javier Sancho <jsancho@bespin>

[FIX] account_payment_export: make payments calling parent class

10. By Javier Sancho <jsancho@bespin>

[FIX] account_payment_sepa_direct_debit: fix XML for mandate views

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches