Merge lp://qastaging/~jtasker/weather-indicator/cloudy into lp://qastaging/weather-indicator
| Status: | Merged |
|---|---|
| Approved by: | Joshua Tasker |
| Approved revision: | 325 |
| Merged at revision: | 312 |
| Proposed branch: | lp://qastaging/~jtasker/weather-indicator/cloudy |
| Merge into: | lp://qastaging/weather-indicator |
| Diff against target: |
5722 lines (+2158/-964) 16 files modified
AUTHORS (+1/-0) bin/indicator-weather (+1225/-641) data/indicator-weather.gschema.xml (+25/-0) data/ui/Assistant.ui (+85/-40) data/ui/ExtendedForecast.ui (+129/-14) data/ui/PreferencesDialog.ui (+454/-97) debian/changelog (+35/-0) debian/control (+26/-19) debian/copyright (+29/-10) debian/indicator-weather.install (+1/-0) debian/postinst (+6/-7) debian/rules (+10/-4) indicator_weather/helpers.py (+9/-9) indicator_weather/indicator_weatherconfig.py (+2/-2) po/indicator-weather.pot (+117/-118) setup.py (+4/-3) |
| To merge this branch: | bzr merge lp://qastaging/~jtasker/weather-indicator/cloudy |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vadim Rutkovsky | Approve | ||
|
Review via email:
|
|||
Description of the change
This fixes all the "SIGSEGV" bugs related to glib/dbus; (libdbus is not thread-safe - I re-wrote some of the threading code to deal with this)
I also updated it to use Gtk3 and GObject, instead of the now-deprecated PyGtk.
Finally, I added code to calculate humidex/wind chill, and added a related tab to the Preferences Dialog.
Note that this version requires pywapi 0.3.1, which is available here:
http://
deb packages for pywapi 0.3.1 are available here:
https:/
From the changelog:
* Ported to GTK3 and GObject from PyGTK
* Rewrite threading code to avoid dbus-related crashes (LP: #743541)
* Added "feels like" temperature (humidex/heat index/wind chill)
* New "Conditions" tab in Preferences dialog to choose temperature
formulas and toggle display of some condition information
* Bumped version number to reflect massive changes
Note that it still sometimes gives LIBDBUSMENU-GLIB warnings to .xsession-errors, but they can be safely ignored - I have left it running for a week straight with no crashes.
| Joshua Tasker (jtasker) wrote | # |
The dbus-related bug I am talking about is this one: https:/