Merge lp://qastaging/~jtv/simplestreams/streamline-read_signed into lp://qastaging/~smoser/simplestreams/trunk
| Status: | Merged |
|---|---|
| Merge reported by: | Scott Moser |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~jtv/simplestreams/streamline-read_signed |
| Merge into: | lp://qastaging/~smoser/simplestreams/trunk |
| Diff against target: |
48 lines (+9/-11) 1 file modified
simplestreams/util.py (+9/-11) |
| To merge this branch: | bzr merge lp://qastaging/~jtv/simplestreams/streamline-read_signed |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Scott Moser | Pending | ||
|
Review via email:
|
|||
Commit message
Streamline content-lines iteration in read_signed. Remove unused variable.
Description of the change
The code in read_signed that iterates over lines of content was going through some unnecessary contortions. This branch makes no functional changes, but cleans that loop up a bit, and removes a variable that was assigned but never used. (It does keep the intended side effects of the assignment).
By the way, as far as I can make out in the noisy output, the pylint checker invoked by "make lint" did not notice the unused variable. On the other hand, it does complain about invoking print (keyword in python 2, function in 3) with parentheses! I would recommend running flake8 instead.
While I'm here, I would like to suggest another change to read_signed: could we make it take a list of keyrings?
Jeroen
| Scott Moser (smoser) wrote | # |
just for the record, this ended up getting fixed way later under bug 1580534.
fixed now.