Merge lp://qastaging/~julian-edwards/launchpad/sponsor-syncs-bug-827555 into lp://qastaging/launchpad
Proposed by
Julian Edwards
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Julian Edwards | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 14445 | ||||
| Proposed branch: | lp://qastaging/~julian-edwards/launchpad/sponsor-syncs-bug-827555 | ||||
| Merge into: | lp://qastaging/launchpad | ||||
| Diff against target: |
475 lines (+122/-28) 9 files modified
lib/lp/soyuz/browser/tests/test_archive_webservice.py (+9/-5) lib/lp/soyuz/interfaces/archive.py (+24/-5) lib/lp/soyuz/interfaces/packagecopyjob.py (+9/-1) lib/lp/soyuz/model/archive.py (+7/-4) lib/lp/soyuz/model/packagecopyjob.py (+25/-8) lib/lp/soyuz/scripts/packagecopier.py (+12/-2) lib/lp/soyuz/scripts/tests/test_copypackage.py (+27/-0) lib/lp/soyuz/tests/test_archive.py (+6/-2) lib/lp/soyuz/tests/test_packagecopyjob.py (+3/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~julian-edwards/launchpad/sponsor-syncs-bug-827555 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=benji][bug=827555] Make the package copier accept a "sponsored" Person which will be used as the SPPH.creator and From: address on announcement emails. Also expose the new parameter on IArchive.
Description of the change
Make the Soyuz package copier accept a "sponsored" IPerson parameter which the Ubuntu guys need to use to show sponsored syncs from Debian. It will store the "sponsored" user as the creator on the source publication and then make sure that any announcement emails have that user as the From: address.
In addition, there are changes to packagecopyjob and the webservice API to support the new parameter.
UI changes will happen in a future branch.
To post a comment you must log in.
Revision history for this message
| Benji York (benji) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I may be misunderstanding, but this bit (which exists in many different
places, but this is representative) doesn't seem right to me:
:param sponsored: The user who is being sponsored to make the copy.
From the MP and the behavior, it seems to me that it is not a person
being sponsored, but a person who is sponsoring (sponsoring the copy).
If so, the attribute name(s) of "sponsored" would better be "sponsor"
and the description something like "The user who is sponsoring this
copy."