Merge lp://qastaging/~juliank/ddeb-retriever/add-security into lp://qastaging/ddeb-retriever

Proposed by Julian Andres Klode
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp://qastaging/~juliank/ddeb-retriever/add-security
Merge into: lp://qastaging/ddeb-retriever
Diff against target: 20 lines (+2/-1)
1 file modified
ddeb_retriever.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~juliank/ddeb-retriever/add-security
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Colin Watson (community) Needs Information
Review via email: mp+337900@code.qastaging.launchpad.net

Description of the change

Add -security pockets. This change has not been tested, and I expect it will wreak some havoc, at least indexing should take a bit more time than normally.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

What's the motivation for this? -security is synced into -updates quite promptly, so this shouldn't be necessary.

review: Needs Information
Revision history for this message
Julian Andres Klode (juliank) wrote :

I'm not sure, I don't remember. I'll see if I can figure out what I thought back then.

As a quick thought, maybe it's a problem in case -updates gets a new update replacing the security one and you need ddebs for a machine without updates enabled? But not sure.

Revision history for this message
Martin Pitt (pitti) wrote :

I didn't do that back then as it just caused redundant scanning and downloading work. At least during my time, security updates were always also published to -updates at the same time.

Revision history for this message
Steve Langasek (vorlon) wrote :

Rejected based on the comment history (and now trying to move this repo to git)

review: Disapprove

Unmerged revisions

177. By Julian Andres Klode

ddeb_retriever.py: Add -security pockets

This might wreak havoc, beware.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches