Merge lp://qastaging/~juliank/ubuntu-release-upgrader/valid-release into lp://qastaging/ubuntu-release-upgrader

Proposed by Julian Andres Klode
Status: Merged
Approved by: Julian Andres Klode
Approved revision: 3096
Merged at revision: 3095
Proposed branch: lp://qastaging/~juliank/ubuntu-release-upgrader/valid-release
Merge into: lp://qastaging/ubuntu-release-upgrader
Diff against target: 75 lines (+19/-2)
4 files modified
DistUpgrade/DistUpgradeController.py (+2/-0)
debian/changelog (+3/-0)
tests/data-sources-list-test/sources.list.obsolete_mirror (+1/-0)
tests/test_sources_list.py (+13/-2)
To merge this branch: bzr merge lp://qastaging/~juliank/ubuntu-release-upgrader/valid-release
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement (community) Approve
Ubuntu Core Development Team Pending
Review via email: mp+336761@code.qastaging.launchpad.net

Description of the change

+ * DistUpgradeController.py: Only add a new entry for previously
+ unknown mirrors if the new entries distro is a valid release.
+ (LP: #1744722)

To post a comment you must log in.
3096. By Julian Andres Klode

Add test case for bug #1744722

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

LGTM. I also verified that with the sources.list files provided in bug 1744722 the bug is fixed. I tried to add various erroneous entries and sources.list is valid after rewrite. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches