Ubuntu
apport package

Merge lp://qastaging/~juliank/ubuntu/bionic/apport/snap into lp://qastaging/~ubuntu-core-dev/ubuntu/bionic/apport/ubuntu

  1. Bionic (18.04)
  2. snap
  3. Merge into ubuntu
Proposed by Julian Andres Klode
Status: Merged
Merged at revision: 2621
Proposed branch: lp://qastaging/~juliank/ubuntu/bionic/apport/snap
Merge into: lp://qastaging/~ubuntu-core-dev/ubuntu/bionic/apport/ubuntu
Diff against target: 115 lines (+50/-2) (has conflicts)
3 files modified
apport/ui.py (+40/-2)
debian/changelog (+9/-0)
debian/control (+1/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp://qastaging/~juliank/ubuntu/bionic/apport/snap
Reviewer Review Type Date Requested Status
Brian Murray Approve
Steve Langasek Needs Fixing
Review via email: mp+342207@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
Revision history for this message
Julian Andres Klode (juliank) :
lp://qastaging/~juliank/ubuntu/bionic/apport/snap updated
2620. By Julian Andres Klode

Change "The report belongs to a" to "This report is about a"

2621. By Julian Andres Klode

Tweak forum.snapcraft.io message

2622. By Julian Andres Klode

Clarify situation where both deb and snap are installed

Revision history for this message
Steve Langasek (vorlon) wrote :

looks good, a few small language tweaks only.

review: Needs Fixing
Revision history for this message
Brian Murray (brian-murray) wrote :

I think there a couple of instances where we will know whether or not the report should be about the deb package. In the event that information is being collected about a crash then ExecutablePath will be set and we can check if that is from a snap or a deb package. Additionally, it is possible to use the command ubuntu-bug about a program path. In that case we'd also know whether the program path was from a deb package or a snap. That being said I couldn't easily tell if that information was passed on to ui.py.

review: Needs Fixing
Revision history for this message
Julian Andres Klode (juliank) wrote :

I think the use case we are looking at is apport-bug <package name>, so we can just restrict snap handling to that. (if we crashed in a snap we won't have a cur_package, so we don't even reach that point).

lp://qastaging/~juliank/ubuntu/bionic/apport/snap updated
2623. By Julian Andres Klode

Restrict snap handling to apport-bug <package name>

2624. By Julian Andres Klode

Wording improvements: .deb => deb, "," to "."

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good to me now although we should open a bug about

 809 # executable?
 810 elif '/' in self.args[0]:
 811 pkg = apport.packaging.get_file_package(self.args[0])
 812 if not pkg:
 813 optparser.error('%s does not belong to a package.' % self.args[0])
 814 sys.exit(1)

not working with snaps.

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

I reported the bug https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1760220.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches