Merge lp://qastaging/~junaidali/charm-helpers/interface-based-hostnames into lp://qastaging/charm-helpers
Proposed by
Junaid Ali
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~junaidali/charm-helpers/interface-based-hostnames |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
15 lines (+4/-1) 1 file modified
charmhelpers/contrib/network/ip.py (+4/-1) |
| To merge this branch: | bzr merge lp://qastaging/~junaidali/charm-helpers/interface-based-hostnames |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Page | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Junaid Ali (junaidali) wrote | # |
Unmerged revisions
- 651. By Junaid Ali
-
Workaround for the issue caused by MAAS 2.0 multiple dns entries feature
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Junaidali
Coming at this with some context for the changes in MAAS 2.0 dns, I can see your intent, but I think we need two things before landing this.
1) Some good inline comments explaining what this is intended to fix
2) A set of unit tests to ensure that this all works as intended, and does not get broken in the future.