Merge lp://qastaging/~junrrein/pantheon-files/fix-1085662 into lp://qastaging/~elementary-apps/pantheon-files/trunk

I sort of forgot how to trigger the bug in views other than column view, sorry.

The second commit is to solve this situation:

1) Go to a non-existent directory through the location bar.
2) Go to the parent folder and create that directory.

If you try to see the new directory's properties, it will show nothing, because in step 1 it was cached with a null fileinfo.

I hope you don't condemn me for not filing a bug report about this :P

If you try to trigger the bug using Simon's screen cast as a guide, but you go further and after recreating the directory you also recreate its sub-folder, the files that were under those sub-folders will still show up.

So, when deleting a folder, Files should make sure to also delete its sub-folders from the gof-directory-async cache.

Now it should do.

There is a corner case that my fix doesn't cover.

Let's say you have ~/Test1/Test2/Test3/ bookmarked in your sidebar.
So you access Test3 from the sidebar (caching it).
Then you go back to Home, and delete Test1.
What will happen is that Test3 will not be removed from cache. My fix removes Test1 and tries to remove its children. As Test2 is not cached, the algorithm will stop there.

I couldn't think of a good way to cover this case. Except recreating the entire folder structure for the deleted folder and check for all of its items, but I think this would be too much.

In icon view, open a folder, then start a new tab (tab B). Delete the folder open in tab A. Observe that it is still present in tab A. In tab A click Back then Forward and observe that the folder appears to still exist, although empty.

Cody, I think that the situation you presented belongs in another bug report. The same situation happens no matter what you use to delete the current location of Files (a terminal, another instance of a file manager, etc.) and is not related with a caching issue. It's more about "handling the disappearance of the current folder".

it works for me and the branch be merged in my opinion, waiting for Cody approval/disapproval.