Merge lp://qastaging/~jus/mixxx/skins into lp://qastaging/mixxx/1.9

Proposed by jus
Status: Merged
Merged at revision: 2678
Proposed branch: lp://qastaging/~jus/mixxx/skins
Merge into: lp://qastaging/mixxx/1.9
Diff against target: 2300 lines (+792/-192)
19 files modified
mixxx/res/images/templates/skin_template_outline.svg (+154/-62)
mixxx/res/skins/Deere1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/Deere1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNight1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNight1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNightBlues1280x1024-SXGA/skin.xml (+22/-2)
mixxx/res/skins/LateNightBlues1280x800-WXGA/skin.xml (+22/-2)
mixxx/res/skins/Outline1024x600-Netbook/skin.xml (+97/-22)
mixxx/res/skins/Outline1024x768-XGA/skin.xml (+97/-22)
mixxx/res/skins/Outline800x480-WVGA/skin.xml (+99/-24)
mixxx/res/skins/Phoney1600x1200-UXGA/skin.xml (+22/-2)
mixxx/res/skins/Phoney1680x1050-WSXGA/skin.xml (+22/-2)
mixxx/res/skins/PhoneyDark1600x1200-UXGA/skin.xml (+22/-2)
mixxx/res/skins/PhoneyDark1680x1050-WSXGA/skin.xml (+22/-2)
mixxx/res/skins/Shade1024x600-Netbook/skin.xml (+37/-16)
mixxx/res/skins/Shade1024x768-XGA/skin.xml (+37/-16)
mixxx/res/skins/ShadeDark1024x600-Netbook/skin.xml (+24/-4)
mixxx/res/skins/ShadeDark1024x768-XGA/skin.xml (+24/-4)
mixxx/src/skin/legacyskinparser.cpp (+3/-2)
To merge this branch: bzr merge lp://qastaging/~jus/mixxx/skins
Reviewer Review Type Date Requested Status
Albert Santoni Approve
Review via email: mp+45508@code.qastaging.launchpad.net

Description of the change

Minimal CSS changes to solve cross-platform issues have been made since the last merge to the 1.9 branch (for 1.9beta1). Nonetheless i propose this branch for merging into lp:mixxx/1.9 to be included in the final 1.9 release.
New feature is the visual feedback when searchbox has focus (available for all skins).
Also the open/close triangles for treeview and the splitter between the left/right pane in the library looks now identical on all supported platforms.

Changes tested extensively on MacOS 10.5/10.6 and (K)Ubuntu 10.10.

To post a comment you must log in.
Revision history for this message
Albert Santoni (gamegod) wrote :

Looks great, thanks Jus!

Merged into 1.9 in r2678.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches