Media Hub

Merge lp://qastaging/~justinmcp/media-hub/1603729 into lp://qastaging/media-hub

  1. 1603729
  2. Merge into trunk
Proposed by Justin McPherson
Status: Approved
Approved by: Jim Hodapp
Approved revision: 208
Proposed branch: lp://qastaging/~justinmcp/media-hub/1603729
Merge into: lp://qastaging/media-hub
Diff against target: 206 lines (+36/-39)
5 files modified
src/core/media/engine.h (+1/-2)
src/core/media/gstreamer/engine.cpp (+2/-8)
src/core/media/gstreamer/engine.h (+1/-2)
src/core/media/player_implementation.cpp (+25/-20)
tests/unit-tests/test-gstreamer-engine.cpp (+7/-7)
To merge this branch: bzr merge lp://qastaging/~justinmcp/media-hub/1603729
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+303097@code.qastaging.launchpad.net

Commit message

Fix use of custom headers when working with playlists.

Description of the change

Fix use of custom headers when working with playlists.

To post a comment you must log in.
Revision history for this message
Santosh (santoshbit2007) wrote :

I have just looked into code from coding prespective not other aspects. So I have one comment inline.
Its ok from my side if that is correct.

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

A couple of comments inline.

review: Needs Fixing (code)
Reply
lp://qastaging/~justinmcp/media-hub/1603729 updated
206. By Justin McPherson

Fix typo.

Revision history for this message
Justin McPherson (justinmcp) :
Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good to me. Let me know the silo number and I'll help test this out when it's ready. Thanks man.

review: Approve (code)
Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Santosh, I'll let you top approve once you feel it's good.

Reply
Revision history for this message
David Barth (dbarth) wrote :

@jim: packages now in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-044/+packages

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Thanks David. I tried to install this silo but it causes my turbo device to
not fully boot. It's most likely that media-hub isn't coming up quite right
which is usually the cause for Unity8 not starting which is what I'm seeing.

On Fri, Aug 19, 2016 at 10:37 AM, David Barth <email address hidden>
wrote:

> @jim: packages now in https://launchpad.net/~ci-
> train-ppa-service/+archive/ubuntu/landing-044/+packages
> --
> https://code.launchpad.net/~justinmcp/media-hub/1603729/+merge/303097
> You are reviewing the proposed merge of lp:~justinmcp/media-hub/1603729
> into lp:media-hub.
>

Reply
Revision history for this message
Justin McPherson (justinmcp) wrote :

I've tested this on the devices I have access to; a M10 and a N4. Both boot and work as expected. Both were using OTA-12. Can anyone confirm on other devices?

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

I'll test this on a freshly flashed krillin

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

This is consistent across both turbo and krillin for me. Both devices no longer boot into Unity8 after installing this silo.

review: Needs Fixing
Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

This also needs to be re-synced against lp:media-hub as the latest version info has changed from other landings.

Reply
lp://qastaging/~justinmcp/media-hub/1603729 updated
207. By Justin McPherson

Merge from trunk.

208. By Justin McPherson

Fix merge

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
Reply
lp://qastaging/~justinmcp/media-hub/1603729 updated
209. By Justin McPherson

Merge from trunk.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

What's the latest on this Justin? Do you plan to get this landed soon?

Reply
Revision history for this message
Justin McPherson (justinmcp) wrote :

There was a binary break on trunk, and Oxide needs to be pulled into the silo. I've been working on some urgent tasks, but I'll see if I can push this forward.

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Sounds good Justin. Last I checked this was ready to simply hand over to QA to test for regressions and once they mark it as having passed, land it. Should be minimal work for you.

Reply
lp://qastaging/~justinmcp/media-hub/1603729 updated
210. By Justin McPherson

Merge from trunk.

Unmerged revisions

210. By Justin McPherson

Merge from trunk.

209. By Justin McPherson

Merge from trunk.

208. By Justin McPherson

Fix merge

207. By Justin McPherson

Merge from trunk.

206. By Justin McPherson

Fix typo.

205. By Justin McPherson

Add an empty URI to avoid playlist playback when using custom headers

204. By Justin McPherson

Unify versions of open_resource_for_uri().

Create one code path so logic is easily applied to all.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches