Merge lp://qastaging/~justinmcp/unity-chromium-extension/1469601 into lp://qastaging/unity-chromium-extension

Proposed by Justin McPherson
Status: Needs review
Proposed branch: lp://qastaging/~justinmcp/unity-chromium-extension/1469601
Merge into: lp://qastaging/unity-chromium-extension
Diff against target: 582 lines (+167/-143)
13 files modified
chromium-extension/background-page.js (+63/-60)
chromium-extension/chromium-extension.pro (+3/-3)
chromium-extension/infobar.css (+0/-20)
chromium-extension/infobar.html (+0/-20)
chromium-extension/infobar.js (+0/-33)
chromium-extension/manifest.json.in (+12/-4)
chromium-extension/options.js (+2/-2)
chromium-extension/popup.css (+21/-0)
chromium-extension/popup.html (+20/-0)
chromium-extension/popup.js (+33/-0)
debian/changelog (+7/-0)
debian/control (+1/-1)
messaging-host/main.cpp (+5/-0)
To merge this branch: bzr merge lp://qastaging/~justinmcp/unity-chromium-extension/1469601
Reviewer Review Type Date Requested Status
Alexandre Abreu Pending
WebApps Pending
Review via email: mp+263316@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

lgtm

257. By Justin McPherson

Add check for new enumeration value in Qt >= 5.5.

Unmerged revisions

257. By Justin McPherson

Add check for new enumeration value in Qt >= 5.5.

256. By Justin McPherson <justin@phablet-dev>

WIP

255. By Justin McPherson <justin@phablet-dev>

WIP

254. By Justin McPherson <justin@phablet-dev>

WIP

253. By Justin McPherson <justin@phablet-dev>

WIP

252. By Justin McPherson <justin@phablet-dev>

WIP

251. By Justin McPherson <justin@phablet-dev>

WIP

250. By Justin McPherson <justin@phablet-dev>

WIP

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: