WebApps: unity-chromium-extensions

Merge lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2 into lp://qastaging/~webapps/unity-chromium-extension/staging

native-messaging-2
Merge into staging

Proposed by Justin McPherson on 2014-06-02

Status:	Merged
Approved by:	Alberto Mardegan on 2014-06-02
Approved revision:	267
Merged at revision:	255
Proposed branch:	lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2
Merge into:	lp://qastaging/~webapps/unity-chromium-extension/staging
Diff against target:	882 lines (+590/-102) 12 files modified README (+0/-1) chromium-extension/background-page.js (+4/-4) common-vars.pri (+1/-1) debian/changelog (+5/-5) debian/control (+1/-2) messaging-host/installation-host (+0/-74) messaging-host/main.cpp (+8/-4) messaging-host/messaging-host.pro (+7/-0) messaging-host/webapps-handler.cpp (+208/-10) tests/unit/messaging-host/messaging-host.pro (+2/-1) tests/unit/messaging-host/tst_webapps-handler.cpp (+324/-0) tests/unit/messaging-host/tst_webapps-handler.pro (+30/-0)
To merge this branch:	bzr merge lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alberto Mardegan (community)		2014-06-02	Approve on 2014-06-02
Review via email: mp+221666@code.qastaging.launchpad.net

Revision history for this message

Alberto Mardegan (mardy) wrote on 2014-06-02:

I'll test it soon, meanwhile I've just added some comments about the code.

Revision history for this message

Alberto Mardegan (mardy) wrote on 2014-06-02:

I tested it with launchpad.net, and seems to work well! :-)

review: Approve

lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2 updated on 2014-06-04

268. By Justin McPherson on 2014-06-04: Results of review

Revision history for this message

Justin McPherson (justinmcp) on 2014-06-04:

Revision history for this message

Justin McPherson (justinmcp) wrote on 2014-06-04:

@mardy; I have inverted the result of the installed. It is true that
allowed does not imply installed, but in this scenario, it is correct to
return an installed status.

On Wed, Jun 4, 2014 at 11:30 AM, <email address hidden> wrote:

> The proposal to merge
> lp:~justinmcp/unity-chromium-extension/native-messaging-2 into
> lp:~webapps/unity-chromium-extension/staging has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~justinmcp/unity-chromium-extension/native-messaging-2/+merge/221666
> --
>
> https://code.launchpad.net/~justinmcp/unity-chromium-extension/native-messaging-2/+merge/221666
> You are the owner of
> lp:~justinmcp/unity-chromium-extension/native-messaging-2.
>