Merge lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2 into lp://qastaging/~webapps/unity-chromium-extension/staging
Proposed by
Justin McPherson
| Status: | Merged |
|---|---|
| Approved by: | Alberto Mardegan |
| Approved revision: | 273 |
| Merged at revision: | 260 |
| Proposed branch: | lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2 |
| Merge into: | lp://qastaging/~webapps/unity-chromium-extension/staging |
| Diff against target: |
280 lines (+158/-4) 9 files modified
chromium-extension/background-page.js (+2/-1) messaging-host/main.cpp (+3/-0) messaging-host/messaging-host.pro (+4/-2) messaging-host/webapps-handler.cpp (+42/-1) messaging-host/webapps-handler.h (+10/-0) messaging-host/webapps-process.cpp (+28/-0) messaging-host/webapps-process.h (+37/-0) tests/unit/messaging-host/tst_webapps-handler.cpp (+30/-0) tests/unit/messaging-host/tst_webapps-handler.pro (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~justinmcp/unity-chromium-extension/native-messaging-2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Mardegan (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make sure the webapp indexing process is run
To post a comment you must log in.
Revision history for this message
| Alberto Mardegan (mardy) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Overall looks good (just a couple of inline comments).
Can you please add a unit test for the createApplicati