friends-app

Merge lp://qastaging/~kai-mast/friends-app/lp1168926 into lp://qastaging/friends-app

  1. lp1168926
  2. Merge into trunk
Proposed by Kai Mast
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp://qastaging/~kai-mast/friends-app/lp1168926
Merge into: lp://qastaging/friends-app
Diff against target: 102 lines (+44/-3)
2 files modified
qml/Post.qml (+31/-3)
qml/SettingsProperty.qml (+13/-0)
To merge this branch: bzr merge lp://qastaging/~kai-mast/friends-app/lp1168926
Reviewer Review Type Date Requested Status
Robert Bruce Park Needs Fixing
Review via email: mp+207019@code.qastaging.launchpad.net

Commit message

Remember which services the user wants to post to.

Description of the change

OMG that was so much more complicat ed than I thought. Why do javascript arrays behave so weird?

But should work now :)

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

I'm afraid this isn't working for me. if I disable facebook, then close and relaunch, it remembers to disable facebook. but I can never disable twitter. if I disable everything, then twitter is selected on next startup, and if I choose facebook but disable twitter, then theyre both enabled on next launch.

review: Needs Fixing
Revision history for this message
Kai Mast (kai-mast) wrote :

So strange. I just tested this again and it works completely fine for me.

Could you maybe remove your friends-app settings (.local/share/friends-app/friends-app-settings.u1db) and try again?

Revision history for this message
Robert Bruce Park (robru) wrote :

Hey Kai, sorry for the long delay in testing this. Release was totally hectic, but I've got some more time now ;-)

Unfortunately after deleting that file I still get the same issue. The only way I can get it to remember the state for my twitter account is to disable my facebook account entirely.

How many accounts do you have that you're testing with? When I have two accounts, it just does not remember the state for Twitter, which is second in the list.

Revision history for this message
Kai Mast (kai-mast) wrote :

Mh I also have two accounts. This is really strange.. maybe I should test in a virtual machine or something...

Unmerged revisions

144. By Kai Mast

FINALLY WORKS

143. By Kai Mast

First attempt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: