Merge lp://qastaging/~kai-mast/friends/upstart2 into lp://qastaging/friends
Proposed by
Kai Mast
Status: | Rejected |
---|---|
Rejected by: | Robert Bruce Park |
Proposed branch: | lp://qastaging/~kai-mast/friends/upstart2 |
Merge into: | lp://qastaging/friends |
Diff against target: |
44 lines (+9/-1) 4 files modified
data/friends.conf (+5/-0) debian/control (+1/-1) debian/friends.install (+1/-0) setup.py (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~kai-mast/friends/upstart2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Bruce Park | Disapprove | ||
Ken VanDine | Needs Fixing | ||
Review via email: mp+199361@code.qastaging.launchpad.net |
Description of the change
Cleaned up the upstart changes.
Btw, how is the service currently started? Friends-app does it somehow. Is it done in the QML components? Is this even allowed when an app is confined?
This should not be needed anymore now. If it still needed for some reason the app should call "start friends", so it is tracked by upstart.
To post a comment you must log in.
Looks good to me, but I want to get ken's input on this.