Drizzle Automation

Merge lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/mysql-sysbench-fixes into lp://qastaging/drizzle-automation

  1. mysql-sysbench-fixes
  2. Merge into trunk
Proposed by Lee Bieber
Status: Merged
Approved by: Patrick Crews
Approved revision: 206
Merged at revision: 204
Proposed branch: lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/mysql-sysbench-fixes
Merge into: lp://qastaging/drizzle-automation
Diff against target: 383 lines (+48/-73)
6 files modified
drizzle/automation/client/mysql.py (+3/-3)
drizzle/automation/lib/util.py (+1/-0)
drizzle/automation/reports/dbt2.py (+2/-10)
drizzle/automation/reports/drizzleslap.py (+2/-10)
drizzle/automation/reports/sysbench.py (+31/-41)
drizzle/automation/server/mysqld.py (+9/-9)
To merge this branch: bzr merge lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/mysql-sysbench-fixes
Reviewer Review Type Date Requested Status
Patrick Crews Approve
Review via email: mp+37987@code.qastaging.launchpad.net

Description of the change

Changes to get mysql working again with sysbench

To post a comment you must log in.
Revision history for this message
Jay Pipes (jaypipes) wrote :

If you use --socket, you will be comparing Apples (Drizzle over TCP/IP) with Oranges (MySQL over unix domain sockets).

In addition, --socket=/tmp/mysqld.sock is quite likely to be the socket that the MySQL server used in d-a data collection is on, which will make running d-a a bit, well, unpredictable.

I highly recommend instead using MySQL over TCP/IP, which would mean specifying the MySQL --host and --port properly.

Revision history for this message
Patrick Crews (patrick-crews) wrote :

We were seeing errors about the client trying to connect via the socket file
(grrr) before we started this patch.
Is this a case of needing to use --host=127.0.0.1 vs. localhost (something I
ran into with MySQLDB)?

Anyway, thanks for helping to shed some light here - we might not need to /
would prefer not to deal with the socket stuff, but my MySQL knowledge
wasn't working for me yesterday : )

On Fri, Oct 8, 2010 at 12:18 PM, Jay Pipes <email address hidden> wrote:

> If you use --socket, you will be comparing Apples (Drizzle over TCP/IP)
> with Oranges (MySQL over unix domain sockets).
>
> In addition, --socket=/tmp/mysqld.sock is quite likely to be the socket
> that the MySQL server used in d-a data collection is on, which will make
> running d-a a bit, well, unpredictable.
>
> I highly recommend instead using MySQL over TCP/IP, which would mean
> specifying the MySQL --host and --port properly.
>
>
> --
>
> https://code.launchpad.net/~kalebral/drizzle-automation/mysql-sysbench-fixes/+merge/37987<https://code.launchpad.net/%7Ekalebral/drizzle-automation/mysql-sysbench-fixes/+merge/37987>
> Your team Drizzle Automatons is requested to review the proposed merge of
> lp:~kalebral/drizzle-automation/mysql-sysbench-fixes into
> lp:drizzle-automation.
>

Revision history for this message
Jay Pipes (jaypipes) wrote :

> We were seeing errors about the client trying to connect via the socket file
> (grrr) before we started this patch.
> Is this a case of needing to use --host=127.0.0.1 vs. localhost (something I
> ran into with MySQLDB)?

yup.

> Anyway, thanks for helping to shed some light here - we might not need to /
> would prefer not to deal with the socket stuff, but my MySQL knowledge
> wasn't working for me yesterday : )

np :) Yeah, you can use --socket, but like I say, you'll be comparing apples to oranges. Better to just put host=127.0.0.1 in the config files (and remember to use --host=127.0.0.1 for the client commands too.

-jay

Revision history for this message
Jay Pipes (jaypipes) wrote :

No worries Lee :) It's not at all obvious from MySQL docs...

lp://qastaging/~kalebral-deactivatedaccount/drizzle-automation/mysql-sysbench-fixes updated
206. By Lee Bieber <email address hidden>

Don't use --socket, use --host so that when running benchmarks we are running over tcp/ip similar to what drizzle does

Revision history for this message
Patrick Crews (patrick-crews) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: