Midori Web Browser

Merge lp://qastaging/~kalikiana/midori/dock into lp://qastaging/midori

  1. dock
  2. Merge into trunk
Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp://qastaging/~kalikiana/midori/dock
Merge into: lp://qastaging/midori
Diff against target: 93 lines (+27/-2)
4 files modified
extensions/transfers.vala (+11/-0)
extensions/wscript_build (+3/-1)
midori/midori-view.c (+2/-1)
wscript (+11/-0)
To merge this branch: bzr merge lp://qastaging/~kalikiana/midori/dock
Reviewer Review Type Date Requested Status
Midori Devs Pending
Review via email: mp+166497@code.qastaging.launchpad.net

Description of the change

Show a counter in the dock for in-progress downloads

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

There's no progress at this point. This will require some refactoring beyond this feature.

Reply
Revision history for this message
gue5t gue5t (gue5t) wrote :

A minor question I have is why "libunity" vs. "unity" is chosen in different contexts; all external references seem to have no "lib" prefix.

I haven't tested the code but it looks ok--a nitpick on naming is that the function name "update_dock_item" is not very descriptive of how it works; to me it seems like "add/increase_dock_item_count" would explain the behavior of its parameter.

Reply
Revision history for this message
Julián Unrrein (junrrein) wrote :

Acording to the HIG (http://www.elementaryos.org/docs/human-interface-guidelines/desktop-integration/dock-integration) the purpose of dock badges "is to inform the user that there is something that requires attention without being obtrusive".

I don't think that's the case here. The user is already notified about the download in the main window.

Reply
Revision history for this message
Julián Unrrein (junrrein) wrote :

They would make sense to indicate finished downloads.

Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

The dock is used specifically when the user doesn't see the window. I'm not sure what's obtrusive here.

Reply

Unmerged revisions

6186. By Cris Dywan

Drop urgent hint which is redundant with notifications

6185. By Cris Dywan

Decrease dock count when download stops, it may remain in the list

6184. By Cris Dywan

REname update_dock_item to add_dock_item_count for clarity

6183. By Cris Dywan

Always refer to unity, there's no lib prefix

6182. By Cris Dywan

Show a counter in the dock for in-progress downloads

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: