Merge lp://qastaging/~kalikiana/midori/growl into lp://qastaging/midori

Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp://qastaging/~kalikiana/midori/growl
Merge into: lp://qastaging/midori
Diff against target: 15 lines (+6/-0)
1 file modified
midori/midori-app.c (+6/-0)
To merge this branch: bzr merge lp://qastaging/~kalikiana/midori/growl
Reviewer Review Type Date Requested Status
Cris Dywan Disapprove
André Stösel Needs Fixing
Review via email: mp+167167@code.qastaging.launchpad.net

Description of the change

Fallback to infobar in current tab instead of notification

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

There is currently no way to close the notification.

review: Needs Fixing
Revision history for this message
Cris Dywan (kalikiana) wrote :

I think there's sort of a silent agreement that this isn't a convincing alternative for notifications. It may just be better to actually have a simple popup window implemented by Midori.

review: Disapprove

Unmerged revisions

6192. By Cris Dywan

Fallback to infobar in current tab instead of notification

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: