Merge lp://qastaging/~kamstrup/dee/no-gnuc-const-types into lp://qastaging/dee
Proposed by
Mikkel Kamstrup Erlandsen
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 320 |
| Merged at revision: | 319 |
| Proposed branch: | lp://qastaging/~kamstrup/dee/no-gnuc-const-types |
| Merge into: | lp://qastaging/dee |
| Diff against target: |
183 lines (+15/-15) 14 files modified
dee/dee-file-resource-manager.h (+1/-1) dee/dee-filter-model.h (+1/-1) dee/dee-glist-result-set.h (+2/-0) dee/dee-hash-index.h (+1/-1) dee/dee-index.h (+1/-1) dee/dee-model.h (+1/-1) dee/dee-peer.h (+1/-1) dee/dee-proxy-model.h (+1/-1) dee/dee-resource-manager.h (+1/-1) dee/dee-result-set.h (+1/-1) dee/dee-serializable.h (+1/-1) dee/dee-term-list.h (+1/-1) tests/test-analyzer.c (+1/-1) tests/test-index.c (+1/-3) |
| To merge this branch: | bzr merge lp://qastaging/~kamstrup/dee/no-gnuc-const-types |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Remove G_GNUC_CONST for all dee_*_get_type() functions. It is outright wrong to put that on get_type() function and have just been dragged on since forever in fear of breaking ABI.
Also fixes some compilation warnings in the test suite
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks reasonable, approved.