Merge lp://qastaging/~kamstrup/dee/optimized-getters into lp://qastaging/dee
Proposed by
Mikkel Kamstrup Erlandsen
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michal Hruby | ||||
| Approved revision: | 330 | ||||
| Merged at revision: | 326 | ||||
| Proposed branch: | lp://qastaging/~kamstrup/dee/optimized-getters | ||||
| Merge into: | lp://qastaging/dee | ||||
| Diff against target: |
392 lines (+278/-12) 2 files modified
dee/dee-sequence-model.c (+201/-9) tests/test-benchmark.c (+77/-3) |
||||
| To merge this branch: | bzr merge lp://qastaging/~kamstrup/dee/optimized-getters | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Optimize the getters in DeeSequenceModel by shaving off a g_variant_ref() compared to the default impl in DeeSerializable
This branch also adds a benchmark for reading a string column out of a seqmodel.
It is now possible to pass arguments to tests/test-
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The code looks clean, and I can confirm ~15% speedup in the benchmark. Rock on!