Merge lp://qastaging/~kamstrup/dee/tree-index into lp://qastaging/dee

Wow, this is huge...

There are (closure) annotations missing for DeeModelReaderFunc, DeeCollatorFunc, and all the *_reader helpers.

dee_term_list_clone_real: is trying to be insanely quick, doing memcpy of the ptrarr->data fields could squeeze up some extra performance.

find_term_real: shouldn't it use g_sequence_lookup when doing MATCH_EXACT?

2573 +//fixme fixme - is there something to fix?

Oh yea, and regenerate the Vala bindings please.

Also please add a test that creates TreeIndex on a model that already has a few rows. Hint: it'll crash. ;)

Just pushed fixes for everything except the last crasher you pointed out. I added a failing unit test as well for the latter, but will wait until tomorrow to actually fix it because it'll require some work (the root cause is described in //FIXMEs).

Just pushed a fix for the last issue. Please review again.

I can't say I like the pointer property, and moreover it's copying the delegate which is *really* dangerous if the original was also used. That being said, this allows easy use of the existing readers, so it shouldn't be that bad. But please, make the "reader" property write-only and add one more ModelReader initializer that will have the (ModelReaderFunc, gpointer, GDestroyNotify) parameters.

As I mentioned on IRC, my test still crashes with SIGFPE, and after some digging, it seems it has something to do with the exact data I chose, so adding that here (the clear call crashes):

void lookup_rows (Dee.Index index, string term)
{
  var rs = index.lookup (term, Dee.TermMatchFlag.PREFIX);
  var m = rs.get_model ();
  foreach (var iter in rs)
  {
    debug ("resultset contains iter: %p", iter);
    debug (" data: %d, %s", m.get_int32 (iter, 0), m.get_string (iter, 1));
  }
}

void main ()
{
  var m = new Dee.SequenceModel ();
  m.set_schema ("i", "s");

  var reader = Dee.ModelReader.new_for_string_column (1);

  var i = new Dee.TreeIndex (m, new Dee.TextAnalyzer (), reader);
  m.append (44, "file:///local_uri");
  m.append (23, "http://foo.com");
  m.append (11, "ftp://bar.org");
  m.append (07, "file:///home/username/file@home");

  lookup_rows (i, "user");

  m.clear ();
}

Thanks for spotting this. Finally nailed it and pushed the fixes. See
the commit comments. Please review again.

There are just minor things: ModelReader shouldn't be marked as Compact class (+vapi regen), dee_model_reader_new annotations should have (scope notified) for the first param, the third should be just (allow-none).

Other than that I think we're good. Awesome job! :)

+ unitialized -> initialized :)

> + unitialized -> initialized

Actually, "uninitialized" :)

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-dee/1/console reported an error when processing this lp:~kamstrup/dee/tree-index branch.
Not merging it.