libunity

Merge lp://qastaging/~kamstrup/libunity/now-with-more-keywords into lp://qastaging/libunity

  1. now-with-more-keywords
  2. Merge into trunk
Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Michal Hruby
Approved revision: 122
Merged at revision: 122
Proposed branch: lp://qastaging/~kamstrup/libunity/now-with-more-keywords
Merge into: lp://qastaging/libunity
Diff against target: 85 lines (+22/-3)
3 files modified
src/unity-appinfo-manager.vala (+14/-1)
test/data/applications/ubuntu-about.desktop (+2/-0)
test/vala/test-appinfo-manager.vala (+6/-2)
To merge this branch: bzr merge lp://qastaging/~kamstrup/libunity/now-with-more-keywords
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+94732@code.qastaging.launchpad.net

Description of the change

Support the new standard XDG 'Keywords' field in desktop files

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Gio dropped support for the gnome-specific key, shouldn't we as well? (http://mail.gnome.org/archives/commits-list/2011-December/msg06472.html)

review: Needs Information
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I think we should keep it in for backwards compat. It is more or less free efficiency wise. Also - we still ship a truckload of packages using the X-GNOME-Keywords field.

Revision history for this message
Michal Hruby (mhr3) wrote :

Grepping through my /usr/share/applications shows the key to be mostly gone, but yea, there are still a few non-core-gnome apps using it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches