unity-lens-files

Merge lp://qastaging/~kamstrup/unity-lens-files/bookmarks-handling into lp://qastaging/unity-lens-files

  1. bookmarks-handling
  2. Merge into trunk
Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Merged at revision: 194
Proposed branch: lp://qastaging/~kamstrup/unity-lens-files/bookmarks-handling
Merge into: lp://qastaging/unity-lens-files
Diff against target: 73 lines (+29/-4)
2 files modified
src/daemon.vala (+3/-2)
src/folder.vala (+26/-2)
To merge this branch: bzr merge lp://qastaging/~kamstrup/unity-lens-files/bookmarks-handling
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+77508@code.qastaging.launchpad.net

Description of the change

Open FTP bookmarks in the default handler for inode/directory. This makes FTP bookmarks open in Nautilus. Note this only applies on *bookmarks*. Incidentally this also fixes automounting of remote shares (except in the cases where GIO b0rks it (FTP works well, SSH not so much))

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

> if (launcher == null)

I think we should fallback here to opening it via default handler for the uri scheme.

review: Needs Fixing
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Fallback is handled in:

18 + if (!bookmarks.launch_if_bookmark (uri))
19 + AppInfo.launch_default_for_uri (uri, null);

lp://qastaging/~kamstrup/unity-lens-files/bookmarks-handling updated
194. By Mikkel Kamstrup Erlandsen

Let errors from bookmark launching bubble up to the main activation handler

Revision history for this message
Michal Hruby (mhr3) wrote :

Very well then, let's have some error dialogs :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: