Media Hub

Merge lp://qastaging/~karni/media-hub/media-hub-engine-refactor into lp://qastaging/media-hub/stable

media-hub-engine-refactor
Merge into stable

Proposed by Michał Karnicki on 2016-01-12

Status:	Work in progress
Proposed branch:	lp://qastaging/~karni/media-hub/media-hub-engine-refactor
Merge into:	lp://qastaging/media-hub/stable
Diff against target:	3039 lines (+2913/-9) 12 files modified src/core/media/CMakeLists.txt (+26/-0) src/core/media/engine.h (+6/-9) src/core/media/engine/codec.h (+129/-0) src/core/media/engine/engine.h (+98/-0) src/core/media/engine/engine_skeleton.cpp (+652/-0) src/core/media/engine/engine_skeleton.h (+104/-0) src/core/media/engine/engine_stub.cpp (+365/-0) src/core/media/engine/engine_stub.h (+94/-0) src/core/media/engine/engine_traits.h (+48/-0) tests/unit-tests/CMakeLists.txt (+24/-0) tests/unit-tests/sig_term_catcher.h (+60/-0) tests/unit-tests/test-dbus-engine.cpp (+1307/-0)
To merge this branch:	bzr merge lp://qastaging/~karni/media-hub/media-hub-engine-refactor
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jim Hodapp (community)	code		Needs Fixing on 2016-02-23
Thomas Voß		2016-01-12	Pending
Review via email: mp+282286@code.qastaging.launchpad.net

Description of the change

This is WIP, please ignore this MR.

lp://qastaging/~karni/media-hub/media-hub-engine-refactor updated on 2016-01-27

173. By Michał Karnicki on 2016-01-12: Add simple Engine stub.
174. By Michał Karnicki on 2016-01-12: Add play, stop, pause, seek_to and reset to dbus::Engine stub.
175. By Michał Karnicki on 2016-01-13: WIP
176. By Michał Karnicki on 2016-01-13: WIP.
177. By Michał Karnicki on 2016-01-13: WIP around installing handlers in skeleton.
178. By Michał Karnicki on 2016-01-13: WIP
179. By Michał Karnicki on 2016-01-13: Add missing files.
180. By Michał Karnicki on 2016-01-13: Add dbus cpp codec for Engine::Volume type.
181. By Michał Karnicki on 2016-01-14: Namespace clean-up. Renamed core::media::dbus to more appropriate core::media::engine.
182. By Michał Karnicki on 2016-01-14: Pull out from engine.h to engine_stub and engine_traits.
183. By Michał Karnicki on 2016-01-14: Started first test. WIP.
184. By Michał Karnicki on 2016-01-14: Further stub work. Compiles.
185. By Michał Karnicki on 2016-01-14: DBus engine play method test. WIP.
186. By Michał Karnicki on 2016-01-14: Added MockEngine.
187. By Michał Karnicki on 2016-01-15: Working that test case.
188. By Michał Karnicki on 2016-01-15: Fix indentation.
189. By Michał Karnicki on 2016-01-15: Test builds.
190. By Michał Karnicki on 2016-01-15: play method test is green wohoo
191. By Michał Karnicki on 2016-01-15: Fix indentation.
192. By Michał Karnicki on 2016-01-15: WIP.
193. By Michał Karnicki on 2016-01-15: Use shared_ptr to engine in EngineSkeleton.
194. By Michał Karnicki on 2016-01-15: play, stop, pause, seek_to and reset tests green.
195. By Michał Karnicki on 2016-01-19: Refactor bunch of unit tests to re-use test method body.
196. By Michał Karnicki on 2016-01-20: Add tests for signals over dbus.
197. By Michał Karnicki on 2016-01-20: Clean-up.
198. By Michał Karnicki on 2016-01-20: Test signals from engine mock/fake, not from skeleton.
199. By Michał Karnicki on 2016-01-20: Alias core::dbus with dbus namespace.
200. By Michał Karnicki on 2016-01-20: Clean-up.
201. By Michał Karnicki on 2016-01-27: Properties over DBus, first pass.
202. By Michał Karnicki on 2016-01-27: Properties over DBus, second pass, two tests disabled.

Revision history for this message

Jim Hodapp (jhodapp) wrote on 2016-02-23:

Looks fantastic Karni, good work so far! Several change suggestions inline below.

review: Needs Fixing (code)

lp://qastaging/~karni/media-hub/media-hub-engine-refactor updated on 2016-02-26

203. By Michał Karnicki on 2016-02-26: Bit of review clean-up.

Revision history for this message

Michał Karnicki (karni) on 2016-02-26:

Unmerged revisions

203. By Michał Karnicki on 2016-02-26: Bit of review clean-up.
202. By Michał Karnicki on 2016-01-27: Properties over DBus, second pass, two tests disabled.
201. By Michał Karnicki on 2016-01-27: Properties over DBus, first pass.
200. By Michał Karnicki on 2016-01-20: Clean-up.
199. By Michał Karnicki on 2016-01-20: Alias core::dbus with dbus namespace.
198. By Michał Karnicki on 2016-01-20: Test signals from engine mock/fake, not from skeleton.
197. By Michał Karnicki on 2016-01-20: Clean-up.
196. By Michał Karnicki on 2016-01-20: Add tests for signals over dbus.
195. By Michał Karnicki on 2016-01-19: Refactor bunch of unit tests to re-use test method body.
194. By Michał Karnicki on 2016-01-15: play, stop, pause, seek_to and reset tests green.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Michał Karnicki

Ubuntu Phablet Team