Merge lp://qastaging/~kazade/wingpanel/indicator-loading into lp://qastaging/~elementary-pantheon/wingpanel/wingpanel

Proposed by Kazade
Status: Superseded
Proposed branch: lp://qastaging/~kazade/wingpanel/indicator-loading
Merge into: lp://qastaging/~elementary-pantheon/wingpanel/wingpanel
Diff against target: 53 lines (+26/-3)
2 files modified
wingpanel-config.vala (+1/-1)
wingpanel-indicator-file-model.vala (+25/-2)
To merge this branch: bzr merge lp://qastaging/~kazade/wingpanel/indicator-loading
Reviewer Review Type Date Requested Status
Cris Dywan (community) Needs Fixing
Review via email: mp+44451@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2010-12-23.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Please use critical() instead of print(), since the panel is unusable in that case. And please limit the lines to ~80 columns.

review: Needs Fixing
22. By Kazade

Use critical, rather than print, if no indicator directory is found.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches