Mir

Merge lp://qastaging/~kdub/mir/0.20.1-fix-1549226 into lp://qastaging/mir/0.20

  1. 0.20.1-fix-1549226
  2. Merge into 0.20
Proposed by Kevin DuBois
Status: Merged
Merged at revision: 3325
Proposed branch: lp://qastaging/~kdub/mir/0.20.1-fix-1549226
Merge into: lp://qastaging/mir/0.20
Diff against target: 639 lines (+129/-58)
17 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+12/-0)
src/platforms/android/server/cmdstream_sync_factory.h (+6/-0)
src/platforms/android/server/device_quirks.cpp (+29/-7)
src/platforms/android/server/device_quirks.h (+1/-0)
src/platforms/android/server/display_component_factory.h (+2/-0)
src/platforms/android/server/egl_sync_factory.cpp (+5/-0)
src/platforms/android/server/hal_component_factory.cpp (+22/-10)
src/platforms/android/server/hal_component_factory.h (+9/-3)
src/platforms/android/server/platform.cpp (+12/-8)
src/platforms/android/server/platform.h (+0/-2)
tests/include/mir/test/doubles/stub_display_builder.h (+5/-0)
tests/unit-tests/graphics/android/test_device_detection.cpp (+7/-7)
tests/unit-tests/graphics/android/test_display_hotplug.cpp (+5/-0)
tests/unit-tests/graphics/android/test_output_builder.cpp (+7/-10)
tests/unit-tests/graphics/android/test_platform.cpp (+4/-8)
tests/unit-tests/graphics/android/test_server_interpreter.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~kdub/mir/0.20.1-fix-1549226
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Fixing
Andreas Pokorny (community) Approve
Cemil Azizoglu (community) Approve
Review via email: mp+287082@code.qastaging.launchpad.net

Commit message

release mir 0.20.1 to fix: LP: #1549226 by correcting the autodetection of the arale device. Also properly connect up the the option for the eglsync quirk.

Description of the change

release mir 0.20.1 to fix: LP: #1549226 by correcting the autodetection of the arale device. Also properly connect up the the option for the eglsync quirk.

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

I recommend the fix to contain only the minimally needed code changes. And leave the shuffling out of the release if you can. But ultimately it's up to you.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

I couldn't convince myself that the nested server would use the autodetection of the device name properly as I thought about the code, so I think its probably safer to take the full fix for 0.20.1. (maybe an oversight when moving some of the egl code to within the android platform directories)

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

yes solves the problem on mx4

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) Needs fixing: Capitalization and punctuation:

23 + . no abi changes in any libraries. bugfix release only

(2) Needs information: Probably a good idea to wait briefly and get approval on the other branch targeting lp:mir before proceeding here.

(3) I suggest describing the bug by its symptoms and not its fix:

24 + - Bugs fixed:
25 + . Accommodate system image device name change for arale device
26 + that broke android quirk detection (LP: #1549226)

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Never mind. I can just merge it by hand and fix it by hand...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches