Merge lp://qastaging/~kdub/mir/android-physical-size into lp://qastaging/mir
Proposed by
Kevin DuBois
Status: | Merged |
---|---|
Approved by: | Kevin DuBois |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2386 |
Proposed branch: | lp://qastaging/~kdub/mir/android-physical-size |
Merge into: | lp://qastaging/mir |
Diff against target: |
131 lines (+43/-14) 2 files modified
src/platforms/android/server/hwc_blanking_control.cpp (+14/-1) tests/unit-tests/graphics/android/test_hwc_configuration.cpp (+29/-13) |
To merge this branch: | bzr merge lp://qastaging/~kdub/mir/android-physical-size |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Chris Halse Rogers | Approve | ||
Daniel van Vugt | Approve | ||
Alan Griffiths | Approve | ||
Robert Carr (community) | Approve | ||
Review via email:
|
Commit message
android: pass the reported physical size of the display from the driver to the rest of the mir system.
fixes: lp: #1430315
Description of the change
android: pass the reported physical size of the display from the driver to the rest of the mir system.
To post a comment you must log in.
Mostly OK. But...
72 -TEST_F( HwcConfiguratio n, no_fpe_ from_malformed_ refresh) HwcConfiguratio n, no_fpe_ from_malformed_ refresh_ or_dpi)
73 +TEST_F(
"no_fpe_ from_malformed_ refresh_ or_dpi" is a bit hard to parse (especially as what the test does).
"no_fpe_ or_dpi_ from_malformed_ refresh" is probably better, but breaks the "one test per condition" rule.